Skip to content

go/build: documentation for Context still mentions +build rather than go:build #54181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Aug 1, 2022 · 1 comment
Closed

go/build: documentation for Context still mentions +build rather than go:build #54181

findleyr opened this issue Aug 1, 2022 · 1 comment
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@findleyr
Copy link
Member

findleyr commented Aug 1, 2022

I noticed that some of the internal commentary in go/build/build.go still refers (exclusively) to +build lines rather than go:build. In one place this leaks in external documentation: the documentation for go/build.Context. We should update that to refer to go:build, to be consistent with the package documentation.

Milestoning for 1.20 since it is not urgent.

CC @bcmills
@findleyr findleyr added this to the Go1.20 milestone Aug 1, 2022
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Aug 1, 2022
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 1, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/437995 mentions this issue: go/build: replace +build with go:build in documentation

@golang golang locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@gopherbot @seankhliao @findleyr