Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: export errCannotRewind #54173

Open
dillonstreator opened this issue Aug 1, 2022 · 4 comments · May be fixed by #54176
Open

net/http: export errCannotRewind #54173

dillonstreator opened this issue Aug 1, 2022 · 4 comments · May be fixed by #54176
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@dillonstreator
Copy link

go/src/net/http/transport.go

Line 628 in dee3efd

var errCannotRewind = errors.New("net/http: cannot rewind body after connection loss")

I'm having to resort to string matching to identify this error which is not ideal

strings.Contains(err.Error(), "net/http: cannot rewind body after connection loss")

I'd love to just be able to use errors.Is

errors.Is(err, http.ErrCannotRewind)
@dillonstreator dillonstreator linked a pull request Aug 1, 2022 that will close this issue
Open
@gopherbot
Copy link

Change https://go.dev/cl/420574 mentions this issue: net/http: export errCannotRewind``

dillonstreator added a commit to dillonstreator/go that referenced this issue Aug 1, 2022
@dillonstreator
net/http: export errCannotRewind
fe1da69 
Fixes golang#54173
@neild
Copy link
Contributor

neild commented Aug 1, 2022

What is the use case for distinguishing this error?

@dillonstreator
Copy link
Author

What is the use case for distinguishing this error?

controlling a log level

@dmitshur dmitshur changed the title net/http export errCannotRewind net/http: export errCannotRewind Aug 2, 2022
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 2, 2022
@dmitshur dmitshur added this to the Backlog milestone Aug 2, 2022
@neild
Copy link
Contributor

neild commented Aug 2, 2022

I don't think this is an error we want to expose. We generally only add distinguishable errors for conditions where code can make a meaningful choice depending on the type of error; this doesn't seem to be such a case.

If we did want to expose this condition, simply exporting errCannotRewind would not be sufficient, since it's only used by the HTTP/1 implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

net/http: export errCannotRewind dillonstreator/go
4 participants
@neild @dmitshur @gopherbot @dillonstreator