Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: use the legacy ping command with the v1 client #54171

Closed
cagedmantis opened this issue Aug 1, 2022 · 1 comment
Closed

x/build/cmd/gomote: use the legacy ping command with the v1 client #54171

cagedmantis opened this issue Aug 1, 2022 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

The gomote command is currently using the v2 logic for the legacy command path. This should be using the legacy ping logic for the legacy command path.

@golang/release @cherrymui
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 1, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Aug 1, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/420536 mentions this issue: cmd/gomote: use legacy ping logic with v1 gomote commands

@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot