Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/coordinator/remote: remove the flag requirement for non-hermetic gomote instances #54137

Closed
cagedmantis opened this issue Jul 29, 2022 · 1 comment
Closed

x/build/internal/coordinator/remote: remove the flag requirement for non-hermetic gomote instances #54137

cagedmantis opened this issue Jul 29, 2022 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@cagedmantis
Copy link
Contributor

When a user requests a non-hermetic gomote instance, they are required to pass the --i-will-not-break-the-host flag when initiating an SSH session. We should remove the requirement for that flag and instead opt to print a warning to the user when the user initiates a session.

This is currently broken in the V2 SSH server.

@golang/release @prattmic
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jul 29, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Jul 29, 2022
@gopherbot
Copy link

Change https://go.dev/cl/420535 mentions this issue: internal/coordinator/remote: remove hermetic flag requirement

@dmitshur dmitshur added this to In Progress in Go Release Team Aug 1, 2022
@dmitshur dmitshur modified the milestones: Backlog, Unreleased Aug 1, 2022
Go Release Team automation moved this from In Progress to Done Aug 2, 2022
@golang golang locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot