Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/xml: crash on android/arm64 due to https://go.dev/cl/417062 [1.18 backport] #54128

Closed
gopherbot opened this issue Jul 29, 2022 · 2 comments
Closed

encoding/xml: crash on android/arm64 due to https://go.dev/cl/417062 [1.18 backport] #54128

gopherbot opened this issue Jul 29, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18.6

Comments

@gopherbot
Copy link

@cherrymui requested issue #53814 to be considered for backport to the next 1.18 minor release.

@gopherbot please backport this. This causes failures on release branches and is a test-only skip.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 29, 2022
@gopherbot gopherbot mentioned this issue Jul 29, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.6 milestone Jul 29, 2022
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 3, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/421094 mentions this issue: [release-branch.go1.18] encoding/xml: skip TestCVE202230633 for short tests

@gopherbot
Copy link
Author

Closed by merging fcdd099 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Aug 3, 2022
@rolandshoemaker @dmitshur
[release-branch.go1.18] encoding/xml: skip TestCVE202230633 for short…
fcdd099 
… tests

TestCVE202230633 uses a bunch of memory, and the input cannot be
feasibly reduced while maintaining the behavior hasn't regressed. This
test could be reasonably removed, but I'd rather keep it around if we
can.

Updates #53814.
Fixes #54128.

Change-Id: Ie8b3f306efd20b2d9c0fb73122c26351a55694c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/417655
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 783ff7d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/421094
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.18.6
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot