Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: do not suggest "go get package" quickfix if the package is not importable #54089

Open
hyangah opened this issue Jul 25, 2022 · 0 comments
Open

x/tools/gopls: do not suggest "go get package" quickfix if the package is not importable #54089

hyangah opened this issue Jul 25, 2022 · 0 comments
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Jul 25, 2022

When a package path includes internal and the current package is not sharing the package path prefix,
that is an error and the quick fix that suggests go get is misleading.
@hyangah hyangah transferred this issue from golang/vscode-go Jul 27, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 27, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jul 27, 2022
@dle8 dle8 modified the milestones: Unreleased, gopls/later Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @dle8