Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: send CLs to release coordinators #54068

Closed
heschi opened this issue Jul 26, 2022 · 5 comments
Closed

x/build/cmd/relui: send CLs to release coordinators #54068

heschi opened this issue Jul 26, 2022 · 5 comments
Assignees
@heschi
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Jul 26, 2022

relui currently doesn't set any reviewers on the CLs it mails, which means you have to go digging through the logs to find them. It should send them to the release coordinators; we already sort of know who they are for the release announcement. We can use the gophers package for this if we want, or read user info from Gerrit.
@heschi heschi added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jul 26, 2022
@heschi heschi added this to the Unreleased milestone Jul 26, 2022
@heschi heschi added this to In Progress in Go Release Team Jul 26, 2022
@gopherbot
Copy link

Change https://go.dev/cl/423335 mentions this issue: internal/task: explode AnnounceRelease arguments

@gopherbot
Copy link

Change https://go.dev/cl/423336 mentions this issue: internal/relui/task: explode TweetRelease arguments

@gopherbot
Copy link

Change https://go.dev/cl/423338 mentions this issue: internal/relui,internal/task: send CLs to coordinators

@gopherbot
Copy link

Change https://go.dev/cl/423337 mentions this issue: internal/relui: clean up redundancies

@gopherbot
Copy link

Change https://go.dev/cl/423340 mentions this issue: internal/gophers: update

@heschi heschi self-assigned this Aug 12, 2022
gopherbot pushed a commit to golang/build that referenced this issue Aug 15, 2022
@heschi @gopherbot
internal/task: explode AnnounceRelease arguments
06090be 
Rather than accepting a struct, which required a lot of glue code,
accept arguments directly. This is an intermediate step for
reviewability; TweetRelease is next.

For golang/go#54068.

Change-Id: I4a418970b05271a6a90c991fcd59b293efec386e
Reviewed-on: https://go-review.googlesource.com/c/build/+/423335
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Aug 15, 2022
@heschi @gopherbot
internal/task: explode TweetRelease arguments
1b10ad8 
Similarly to the previous CL, pass individual arguments to TweetRelease
rather than a single struct.

For golang/go#54068.

Change-Id: I270360113adb785b661c6df4ba2789c6a1e539b7
Reviewed-on: https://go-review.googlesource.com/c/build/+/423336
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 15, 2022
@heschi @gopherbot
internal/gophers: update
12c20b8 
In golang/go#54068 I plan to use this package to derive first names. Better get
it right.

Change-Id: Id6a52f4686fb4c400dc6aa477a80a4007e7ab1a2
Reviewed-on: https://go-review.googlesource.com/c/build/+/423340
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Aug 15, 2022
@heschi
internal/relui: clean up redundancies
65a42b4 
With all the arguments exploded, it became clearer that most of the
duplication between announcement flows is unnecessary. Unify them.

Also remove always-nil error returns I noticed along the way.

For golang/go#54068.

Change-Id: Ibf1c619fe2d08b0efd071152b18a543d89e2d883
Reviewed-on: https://go-review.googlesource.com/c/build/+/423337
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Go Release Team automation moved this from In Progress to Done Aug 16, 2022
@golang golang locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heschi heschi

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @heschi