Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo: TestSignalForwardingExternal sometimes fails with wrong signal SIGINT [1.18 backport] #54056

Closed
gopherbot opened this issue Jul 25, 2022 · 2 comments
Closed

misc/cgo: TestSignalForwardingExternal sometimes fails with wrong signal SIGINT [1.18 backport] #54056

gopherbot opened this issue Jul 25, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18.6

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #53907 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18.

This is a test-only fix that avoids occasional test failures on s390x and possibly other systems.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 25, 2022
@gopherbot gopherbot mentioned this issue Jul 25, 2022
Closed
@gopherbot gopherbot modified the milestones: Go1.18.5, Go1.18.6 Jul 25, 2022
@dmitshur dmitshur mentioned this issue Aug 3, 2022
Closed
@joedian joedian added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 10, 2022
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 10, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/425486 mentions this issue: [release-branch.go1.18] misc/cgo/testcarchive: permit SIGQUIT for TestSignalForwardingExternal

@gopherbot
Copy link
Author

Closed by merging db26851 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Aug 29, 2022
@ianlancetaylor @heschi
[release-branch.go1.18] misc/cgo/testcarchive: permit SIGQUIT for Tes…
db26851 
…tSignalForwardingExternal

Occasionally the signal will be sent to a Go thread, which will cause
the program to exit with SIGQUIT rather than SIGSEGV.

Add TestSignalForwardingGo to test the case where the signal is
expected to be delivered to a Go thread.

This is a roll forward of CL 419014 which was rolled back in CL 424954.
This CL differs from 419014 in that it skips TestSignalForwardingGo
on darwin-amd64.

For #53907
Fixes #54056

Change-Id: I5df3fd610c068df3bd48d9b3d7a9379248b97999
Reviewed-on: https://go-review.googlesource.com/c/go/+/425002
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
(cherry picked from commit d05ce23)
Reviewed-on: https://go-review.googlesource.com/c/go/+/425486
Reviewed-by: David Chase <drchase@google.com>
@golang golang locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.18.6
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @joedian