Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/pubsubhelper: Gerrit event URL values include an unnecessary "?usp=email" query #54031

Closed
dmitshur opened this issue Jul 24, 2022 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 24, 2022

A recent Gerrit event from https://pubsubhelper.golang.org/recent looks like this:

{
	"Time": "2022-07-24T18:47:26.542273157Z",
	"Gerrit": {
		"URL": "https://go-review.googlesource.com/c/go/+/418734?usp=email",
		"Project": "go",
		"CommitHash": "e810f8204157253ccc66d7f3b4828551088bcd1a",
		"ChangeNumber": 418734
	}
},

Though it's a valid URL, the inclusion of the the "usp" query parameter in the change URL isn't something the caller will find helpful, and it's not helping the maintner corpus size either. We can trivially omit it.

Edit: This event is used only to wake up the maintnerd server, its content doesn't contribute to corpus size.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jul 24, 2022
@dmitshur dmitshur added this to the Unreleased milestone Jul 24, 2022
@gopherbot
Copy link

Change https://go.dev/cl/419374 mentions this issue: cmd/pubsubhelper: drop USP parameter from Gerrit CL URLs

@golang golang locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants