Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix/linux: mkall.go runs targets single threaded #54009

Closed
ctII opened this issue Jul 22, 2022 · 3 comments
Closed

x/sys/unix/linux: mkall.go runs targets single threaded #54009

ctII opened this issue Jul 22, 2022 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Performance
Milestone
Unreleased

Comments

@ctII
Copy link

ctII commented Jul 22, 2022

What operating system and processor architecture are you using?

GOOS="linux"
GOARCH="amd64"

What did you do?

Ran GOOS="linux" ./mkall.sh

What did you see?

All targets are seemly run single threaded leading to a runtime of roughly 29-30 minutes

What did you expect to see?

Multiple architecture's targets being worked on at roughly the same time, decreasing time taken to generate relevant files.
Some preliminary tests shows a speedup to about 7 minutes with parts of the targets being done in separate goroutines, with a i7-7700HQ 4c8t
@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2022
@cherrymui
Copy link
Member

@ctII thanks for the issue. Sounds like you're working on improving it? Would you like to send a CL? (See https://go.dev/doc/contribute for how to contribute to Go.) Thanks.

@cherrymui cherrymui added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. help wanted labels Jul 25, 2022
@ctII
Copy link
Author

ctII commented Jul 25, 2022

@ctII thanks for the issue. Sounds like you're working on improving it? Would you like to send a CL? (See https://go.dev/doc/contribute for how to contribute to Go.) Thanks.

Yes, I am currently working on improving this. I will send a CL

@gopherbot
Copy link

Change https://go.dev/cl/419517 mentions this issue: x/sys: run each mkall.go target in a seperate goroutine

@dmitshur dmitshur changed the title x/sys: unix/linux/mkall.go runs targets single threaded x/sys/unix/linux: mkall.go runs targets single threaded Aug 1, 2022
@dmitshur dmitshur added Performance NeedsFix The path to resolution is known, but the work has not been done. and removed help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 1, 2022
@golang golang locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Performance
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @cherrymui @ctII