Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/gomote: execute command conversion from bytes to strings causing error #54004

Closed
cagedmantis opened this issue Jul 22, 2022 · 1 comment
Closed

x/build/internal/gomote: execute command conversion from bytes to strings causing error #54004

cagedmantis opened this issue Jul 22, 2022 · 1 comment
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

The ExecuteCommand endpoint converts bytes to strings. This is leading to the following error:

v2: unable to execute gomoterun.bat: grpc: error while marshaling: string field contains invalid UTF-8

The solution would be to not convert from bytes to strings on the server.

@golang/release
@thanm
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jul 22, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Jul 22, 2022
@cagedmantis cagedmantis self-assigned this Jul 22, 2022
@gopherbot
Copy link

Change https://go.dev/cl/419078 mentions this issue: internal/gomote, cmd/gomote: execute command returns bytes

@dmitshur dmitshur added this to In Progress in Go Release Team Jul 22, 2022
Go Release Team automation moved this from In Progress to Done Jul 22, 2022
@golang golang locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot