Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: add GetLargePageMinimum #53900

Closed
piotr-sneller opened this issue Jul 15, 2022 · 2 comments
Closed

x/sys/windows: add GetLargePageMinimum #53900

piotr-sneller opened this issue Jul 15, 2022 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@piotr-sneller
Copy link

Hello,

could you please add GetLargePageMinimum() to the windows API wrappers? The VirtualAlloc() flag MEM_LARGE_PAGES is supported, but per the documentation, the block size should then be large page aligned. This alignment information is missing due to the lack of the GetLargePageMinimum() function. The proposed extension closes the gap.

Many thanks for considering my request.
@gopherbot gopherbot added this to the Proposal milestone Jul 15, 2022
@mvdan mvdan changed the title proposal: x/sys: Add GetLargePageMinimum() to windows affected/package: x/sys: proposal: x/sys: Add GetLargePageMinimum() to windows Jul 15, 2022
@ianlancetaylor
Copy link
Contributor

Taking this out of the proposal process, as adding a wrapper for an ordinary Windows call does not require a proposal.

Want to send a patch for this?

@ianlancetaylor ianlancetaylor changed the title proposal: x/sys: Add GetLargePageMinimum() to windows x/sys/windows: add GetLargePageMinimum Jul 20, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 20, 2022
@ianlancetaylor ianlancetaylor added help wanted NeedsFix The path to resolution is known, but the work has not been done. and removed compiler/runtime Issues related to the Go compiler and/or runtime. Proposal labels Jul 20, 2022
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Unreleased Jul 20, 2022
@gopherbot
Copy link

Change https://go.dev/cl/444975 mentions this issue: windows: add GetLargePageMinimum

@golang golang locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @piotr-sneller