Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: use overlays when computing mod tidy diagnostics #53881

Open
findleyr opened this issue Jul 14, 2022 · 0 comments
Open

x/tools/gopls: use overlays when computing mod tidy diagnostics #53881

findleyr opened this issue Jul 14, 2022 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@findleyr
Copy link
Contributor

We currently invalidate mod tidy results whenever metadata changes, but compute diagnostics based on saved files. This can be very confusing as go.mod diagnostics do not match the current workspace state.

With native overlay support, we should be able to make mod tidy diagnostics honor unsaved changes, and should explore updating mod tidy diagnostics whenever metadata changes.
@findleyr findleyr added this to the gopls/later milestone Jul 14, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
2 participants
@gopherbot @findleyr