Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: livelock when computing module graph in a workspace with GOPROXY=off [1.18 backport] #53875

Closed
gopherbot opened this issue Jul 14, 2022 · 3 comments
Closed

cmd/go: livelock when computing module graph in a workspace with GOPROXY=off [1.18 backport] #53875

gopherbot opened this issue Jul 14, 2022 · 3 comments
Assignees
@bcmills
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.18.5

Comments

@gopherbot
Copy link

@bcmills requested issue #53874 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.18 and 1.19
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 14, 2022
@gopherbot gopherbot mentioned this issue Jul 14, 2022
Closed
@bcmills bcmills added the GoCommand cmd/go label Jul 14, 2022
@gopherbot gopherbot added this to the Go1.18.5 milestone Jul 14, 2022
@bcmills
Copy link
Contributor

bcmills commented Jul 14, 2022

This manifests as a livelock in go list (wasting users' CPU cycles and battery power), and the fix is trivial. Approving.

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jul 14, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 14, 2022
@bcmills bcmills self-assigned this Jul 14, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/417656 mentions this issue: cmd/go: avoid re-enqueuing workspace dependencies with errors

@gopherbot
Copy link
Author

Closed by merging be7c681 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Jul 27, 2022
@cherrymui
[release-branch.go1.18] cmd/go: avoid re-enqueuing workspace dependen…
be7c681 
…cies with errors

Fixes #53875.
Updates #53874.

Change-Id: I41ab15cb9b86b807a9d9ad21fe21fb7aa5fbb46f
Reviewed-on: https://go-review.googlesource.com/c/go/+/417594
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit a906d3d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/417656
@golang golang locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.18.5
Development

No branches or pull requests
2 participants
@bcmills @gopherbot