Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: update vulncheck to check stdlib vulnerability #53869

Closed
hyangah opened this issue Jul 14, 2022 · 3 comments
Closed

x/tools/gopls: update vulncheck to check stdlib vulnerability #53869

hyangah opened this issue Jul 14, 2022 · 3 comments
Assignees
@jamalc
Labels
FrozenDueToAge gopls/analysis Issues related to running analysis in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
gopls/v0.9.2

Comments

@hyangah
Copy link
Contributor

hyangah commented Jul 14, 2022

We need to supply the go version to use the feature in https://go-review.googlesource.com/c/vuln/+/415614
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 14, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jul 14, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/v0.9.2 Jul 14, 2022
@findleyr findleyr added the gopls/analysis Issues related to running analysis in gopls label Jul 14, 2022
@jamalc jamalc self-assigned this Jul 20, 2022
@gopherbot
Copy link

Change https://go.dev/cl/418536 mentions this issue: gopls: update golang.org/x/vuln

@gopherbot
Copy link

Change https://go.dev/cl/418538 mentions this issue: gopls/internal/vulncheck: pass go version to vulncheck config

@gopherbot
Copy link

Change https://go.dev/cl/418537 mentions this issue: gopls/internal/govulncheck: sync x/vuln@b9a3ad9

gopherbot pushed a commit to golang/tools that referenced this issue Jul 22, 2022
@jamalc
gopls: update golang.org/x/vuln
a732e45 
For golang/go#53869.

Change-Id: If173f0e7e3a06c11cd358ff9917c73b50d2dcb28
Reviewed-on: https://go-review.googlesource.com/c/tools/+/418536
Run-TryBot: Jamal Carvalho <jamal@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot pushed a commit to golang/tools that referenced this issue Jul 22, 2022
@jamalc
gopls/internal/govulncheck: sync x/vuln@b9a3ad9
126ef8f 
For golang/go#53869

Change-Id: I8cf795b792380596be306b2437e26faf990cff8b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/418537
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
gopherbot pushed a commit to golang/tools that referenced this issue Jul 22, 2022
@jamalc
gopls/internal/vulncheck: pass go version to vulncheck config
7b605f4 
For golang/go#53869

Change-Id: I8c34adaf81415dafb724ca67fa731912832c3ee5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/418538
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@hyangah hyangah closed this as completed Jul 25, 2022
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
@golang golang locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamalc jamalc

Labels
FrozenDueToAge gopls/analysis Issues related to running analysis in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
gopls/v0.9.2
Development

No branches or pull requests
5 participants
@hyangah @julieqiu @gopherbot @jamalc @findleyr