Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: Add workflow navigation & filtering #53859

Closed
toothrot opened this issue Jul 13, 2022 · 5 comments
Closed

x/build/cmd/relui: Add workflow navigation & filtering #53859

toothrot opened this issue Jul 13, 2022 · 5 comments
Assignees
@toothrot
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Jul 13, 2022 •
edited

The current list of workflows in relui is overwhelming. Having multiple concurrent workflows running can get confusing quickly to release coordinators, especially if one fails and needs to be restarted.

Home

  • Sort active workflows at the top
  • Allow archiving of stopped workflows
  • Have workflow type categorization in a left-hand navigation bar on desktop
  • Have anchor (¶ or 🔗) links for each workflow

Side-Navigation

A side-navigation (drawer on mobile) could look similar to:

All Workflows (35)
Next RC (Go 1.19) (3)
Next Minor Release (Go 1.19) (5)
...

Show Workflow

A "show" page for a single workflow would also be useful for people who want to organize what they view by browser tabs.
@toothrot toothrot added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jul 13, 2022
@toothrot toothrot added this to the Unreleased milestone Jul 13, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 13, 2022
@heschi heschi added this to Planned in Go Release Team Jul 26, 2022
@toothrot toothrot moved this from Planned to In Progress in Go Release Team Aug 2, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Aug 2, 2022
@toothrot toothrot self-assigned this Aug 2, 2022
@gopherbot
Copy link

Change https://go.dev/cl/420808 mentions this issue: internal/relui: add workflow details page and new list

gopherbot pushed a commit to golang/build that referenced this issue Aug 9, 2022
@toothrot @gopherbot
internal/relui: add workflow details page and new list
d03101a 
Create a workflow details page, and a corresponding new list view for
all workflows. This makes the homepage dramatically easier to scan.
Also, having a page per workflow will make it easier to refresh and know
which workflow you are looking at.

For golang/go#53859

Change-Id: Ic67652345fb1ef3fb2cbda0fc05529959c9b4d77
Reviewed-on: https://go-review.googlesource.com/c/build/+/420808
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Jenny Rakoczy <jenny@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Jenny Rakoczy <jenny@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/423174 mentions this issue: internal/relui: add filtering and navigation to homepage

gopherbot pushed a commit to golang/build that referenced this issue Aug 11, 2022
@toothrot @gopherbot
internal/relui: add filtering and navigation to homepage
595e59a 
This adds a site-wide navigation bar which filters the workflows visible
on the homepage of relui. The navigation bar highlights the current
filter, or current workflow type being viewed on the show page.

For golang/go#53859

Change-Id: Ibcc9de343872110068bc6271c64e65e04c653be1
Reviewed-on: https://go-review.googlesource.com/c/build/+/423174
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Jenny Rakoczy <jenny@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Jenny Rakoczy <jenny@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/423176 mentions this issue: internal/relui: minor tweak to workflow counts

gopherbot pushed a commit to golang/build that referenced this issue Aug 11, 2022
@toothrot
internal/relui: minor tweak to workflow counts
71bde4d 
Right-align them with some different font-size and padding.

Also fix missing baseLink in workflow navigation.

For golang/go#53859

Change-Id: I16388302272fcd5c11433464705caedc7570adeb
Reviewed-on: https://go-review.googlesource.com/c/build/+/423176
Run-TryBot: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/423043 mentions this issue: internal/relui: show old workflows separately

Go Release Team automation moved this from In Progress to Done Aug 16, 2022
@gopherbot
Copy link

Change https://go.dev/cl/425934 mentions this issue: internal/relui: fix side-navigation highlight

gopherbot pushed a commit to golang/build that referenced this issue Aug 26, 2022
@toothrot @gopherbot
internal/relui: fix side-navigation highlight
04792cf 
The NameParam field was left unset accidentally when adding Others in CL
423043.

Updates golang/go#53859

Change-Id: Ibf3253273dda94d3308e6bb8fe1a09377bd65162
Reviewed-on: https://go-review.googlesource.com/c/build/+/425934
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Jenny Rakoczy <jenny@golang.org>
Auto-Submit: Jenny Rakoczy <jenny@golang.org>
@golang golang locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@toothrot toothrot

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot