-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: release version v0.9.1 #53823
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
Change https://go.dev/cl/417119 mentions this issue: |
Change https://go.dev/cl/417118 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jul 13, 2022
Context in WorkDoneWriter In addition to the original commit description reproduced below, this CL updates gopls/go.mod to include a replace directive for x/tools. CL 409936 eliminated cases where we close over a Context during progress reporting, except in one instance where it wasn't possible: the WorkDoneWriter that must implement the io.Writer interface. Unfortunately it contained a glaring bug that the ctx field was never set, and the regression test for progress reporting during `go generate` was disabled due to flakiness (golang/go#49901). Incidentally, the fundamental problem that CL 409936 addressed may also fix the flakiness of TestGenerateProgress. Fix the bug, and re-enable the test. For golang/go#53781 For golang/go#53823 Change-Id: Ideb99a5525667e45d2e41fcc5078699ba1e0f1a3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/417115 gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> Auto-Submit: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> (cherry picked from commit 459e2b8) Reviewed-on: https://go-review.googlesource.com/c/tools/+/417118 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jul 13, 2022
For golang/go#53823 Change-Id: I25b114561f408322a99a63eb90929f4249127381 Reviewed-on: https://go-review.googlesource.com/c/tools/+/417119 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Peter Weinberger <pjw@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Findley <rfindley@google.com>
Change https://go.dev/cl/417414 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Jul 13, 2022
Remove the replace directive and update x/tools. For golang/go#53823 Change-Id: I78681cfdd84834438d20f3815898b18115e3bf8f Reviewed-on: https://go-review.googlesource.com/c/tools/+/417414 gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Nooras Saba <saba@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
This issue tracks progress toward releasing gopls@v0.9.1, a patch release containing just one CL: a fix for a deterministic crash in the
go:generate
codelens: #53781.The text was updated successfully, but these errors were encountered: