Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys: FreeBSD 11 builders on release-branch.go1.17 broken since CL 415714 #53783

Closed
bcmills opened this issue Jul 11, 2022 · 4 comments
Closed

x/sys: FreeBSD 11 builders on release-branch.go1.17 broken since CL 415714 #53783

bcmills opened this issue Jul 11, 2022 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD
Projects
Go Release Team
Milestone
Go1.17.13

Comments

@bcmills
Copy link
Contributor

bcmills commented Jul 11, 2022

CL 415714 regenerated x/sys with compatibility only for FreeBSD 12 and higher.

However, the FreeBSD 11_4 builders are still configured to run the repo on release-branch.go1.17, and are now failing on that branch.

We should either fix x/sys to restore compatibility until release-branch.go1.17 is no longer being maintained, or explicitly disable this repo on those builders.

(attn @golang/freebsd, @golang/release)
@gopherbot gopherbot added this to the Unreleased milestone Jul 11, 2022
@bcmills bcmills added OS-FreeBSD NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jul 11, 2022
@bcmills bcmills modified the milestones: Unreleased, Go1.17.13 Jul 11, 2022
@paulzhol
Copy link
Member

paulzhol commented Jul 11, 2022 •
edited

FreeBSD 11.4 is EOL since September 30, 2021. release-branch.go1.19 was already branched out. I wouldn't like to revert if 1.17 is about to be dropped.

@bcmills bcmills mentioned this issue Jul 11, 2022
Closed
@bcmills bcmills added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jul 11, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jul 11, 2022

Sounds good. Want to send a CL to disable those builders for the x/sys repo?

@bcmills
Copy link
Contributor Author

bcmills commented Jul 11, 2022

The relevant changes would be here:
https://cs.opensource.google/go/x/build/+/master:dashboard/builders.go;l=1546-1550;drc=3b840f6e8cc9cc3f657fb9b11ad755f990f2efe2
https://cs.opensource.google/go/x/build/+/master:dashboard/builders.go;l=1605-1609;drc=3b840f6e8cc9cc3f657fb9b11ad755f990f2efe2

@gopherbot
Copy link

Change https://go.dev/cl/416894 mentions this issue: dashboard: drop host-freebsd-11_2, host-freebsd-11_4 builders

@dmitshur dmitshur added this to In Progress in Go Release Team Jul 12, 2022
@dmitshur dmitshur moved this from In Progress to Done in Go Release Team Jul 12, 2022
@golang golang locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Go1.17.13
Development

No branches or pull requests
3 participants
@paulzhol @bcmills @gopherbot