Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: server ResponseWriter should implement WriteString(string) error #5377

Closed
bradfitz opened this issue Apr 30, 2013 · 5 comments
Closed

net/http: server ResponseWriter should implement WriteString(string) error #5377

bradfitz opened this issue Apr 30, 2013 · 5 comments
Labels
FrozenDueToAge GarbageCollector
Milestone
Go1.2

Comments

@bradfitz
Copy link
Contributor 

I see people using io.WriteString(rw, s) in http server handlers.

I realize our ResponseWriter doesn't implement WriteString.  It could easily, and that
would then prevent io.WriteString from generating garbage.
@bradfitz
Copy link
Contributor Author

Comment 1:

For after Go 1.1:
https://golang.org/cl/9035043
... no tests or benchmarks yet.

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 2:

Labels changed: added go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 3:

Labels changed: added feature.

@robpike
Copy link
Contributor

robpike commented Aug 20, 2013

Comment 4:

Is this happening?

@bradfitz
Copy link
Contributor Author

Comment 5:

This issue was closed by revision 33d531d.

Status changed to Fixed.

@bradfitz bradfitz self-assigned this Aug 20, 2013
@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GarbageCollector
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
4 participants
@bradfitz @rsc @robpike @gopherbot