Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: ambiguous selector with generic interface & embedded types [1.18 backport] #53723

Closed
gopherbot opened this issue Jul 6, 2022 · 4 comments
Closed

cmd/compile: ambiguous selector with generic interface & embedded types [1.18 backport] #53723

gopherbot opened this issue Jul 6, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.4

Comments

@gopherbot
Copy link

@randall77 requested issue #53419 to be considered for backport to the next 1.18 minor release.

@gopherbot please open a backport issue for 1.18.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 6, 2022
@gopherbot gopherbot mentioned this issue Jul 6, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.4 milestone Jul 6, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/416155 mentions this issue: [release-branch.go1.18] cmd/compile: only check implicit dots for method call enabled by a type bound

gopherbot pushed a commit that referenced this issue Jul 7, 2022
@cuonglm @heschi
[release-branch.go1.18] cmd/compile: only check implicit dots for met…
93aab18 
…hod call enabled by a type bound

Fixes #53723

Change-Id: Ibad64f5c4af2112deeb0a9ecc9c589b17594bd05
Reviewed-on: https://go-review.googlesource.com/c/go/+/414836
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/416155
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link
Author

Closed by merging 93aab18 to release-branch.go1.18.

@heschi
Copy link
Contributor

heschi commented Jul 12, 2022

I merged this CL accidentally, but the cherry-pick seems reasonable retroactively. Approved.

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Jul 12, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 12, 2022
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 14, 2022
@cuonglm @bradfitz
[release-branch.go1.18] cmd/compile: only check implicit dots for met…
2a7cbea 
…hod call enabled by a type bound

Fixes golang#53723

Change-Id: Ibad64f5c4af2112deeb0a9ecc9c589b17594bd05
Reviewed-on: https://go-review.googlesource.com/c/go/+/414836
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/416155
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@RhondaMorrison420
Copy link

Blockchain got disable on July first

@golang golang locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.4
Development

No branches or pull requests
3 participants
@gopherbot @heschi @RhondaMorrison420