Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vulndb: derived symbols missing for reference via closure #53655

Open
neild opened this issue Jul 2, 2022 · 1 comment
Open

x/vulndb: derived symbols missing for reference via closure #53655

neild opened this issue Jul 2, 2022 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@neild
Copy link
Contributor

neild commented Jul 2, 2022

In https://go.dev/cl/415800, we list the handleMessage symbol.

handleMessage is called by handle, and handle is referenced--but not called--by MakeProtocols. We'd expect MakeProtocols to appear in the derived symbols after running vulnreport fix, but it does not, probably because it doesn't actually call handle.
@gopherbot gopherbot added this to the Unreleased milestone Jul 2, 2022
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 6, 2022
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
@julieqiu julieqiu modified the milestones: Unreleased, vuln/unplanned Sep 8, 2022
@zpavlinovic
Copy link
Contributor

An old issue, but do we still need a fix for this?

If MakeProtocols is not (transitively) calling handleMessage, then it won't appear as a derived symbol. There is currently no easy way to change that unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
vuln/unplanned
Development

No branches or pull requests
5 participants
@neild @zpavlinovic @julieqiu @gopherbot @heschi