Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: download button opens new tab #53637

Closed
willfaught opened this issue Jul 1, 2022 · 3 comments
Closed

x/website: download button opens new tab #53637

willfaught opened this issue Jul 1, 2022 · 3 comments
Assignees
@hyangah
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Milestone
pkgsite/backlog

Comments

@willfaught
Copy link
Contributor

What operating system and processor architecture browser are you using (go env)?

macOS Monterey 12.4 (21F79), Safari 15.5 (17613.2.7.1.8)

What did you do?

Went to https://go.dev. Clicked on Download.

What did you expect to see?

The same tab navigate to https://go.dev/dl/.

What did you see instead?

A new tab open and navigate to https://go.dev/dl/.

Please don't spam with extra tabs. I just want to go to the page. I can Cmd-click to open a new tab if I need to.
@gopherbot gopherbot added this to the Unreleased milestone Jul 1, 2022
@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 1, 2022
@gopherbot
Copy link

Change https://go.dev/cl/416177 mentions this issue: _content: stop the download button from opening /dl in a new tab

@jinhongy
Copy link

jinhongy commented Jul 6, 2022

This suggestion make a lot of sense. We opened in a new tab is because by that time it opened the page in "golang.org". Since we have merge this two sites, we should not open in a new tab as the page is no longer an external page.

For the downloading, we can also consider downloading the package based on the operating system instead of taking developers to the "All download" page since we merged these two sites.

@hyangah
Copy link
Contributor

hyangah commented Jul 6, 2022

Thanks for the background.

For general Download/installation UX improvement see

#52491
#52487
#47578

If we can detect the underlying architectures correctly, utilizing go.dev/doc/install (that already detects OS) instead of go.dev/dl is another option.

@jamalc jamalc modified the milestones: Unreleased, pkgsite/later Jul 19, 2022
@golang golang locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
6 participants
@willfaught @dr2chase @hyangah @jinhongy @gopherbot @jamalc