-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: condition in for loop body is incorrectly optimised away [1.18 backport] #53618
Labels
Milestone
Comments
Change https://go.dev/cl/415414 mentions this issue: |
Approved. This is a serious issue with no workaround. |
Closed by merging 5f2dff9 to release-branch.go1.18. |
gopherbot
pushed a commit
that referenced
this issue
Jul 6, 2022
…ion is <= maxint When the terminating condition is <= X, we need to make sure that X+step doesn't overflow. Fixes #53618 Change-Id: I36e5384d05b4d7168e48db6094200fcae409bfe5 Reviewed-on: https://go-review.googlesource.com/c/go/+/415219 Reviewed-by: Than McIntosh <thanm@google.com> Run-TryBot: David Chase <drchase@google.com> Reviewed-by: David Chase <drchase@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Keith Randall <khr@golang.org> (cherry picked from commit 31b8c23) Reviewed-on: https://go-review.googlesource.com/c/go/+/415414 Reviewed-by: Keith Randall <khr@google.com>
bradfitz
pushed a commit
to tailscale/go
that referenced
this issue
Jul 14, 2022
…ion is <= maxint When the terminating condition is <= X, we need to make sure that X+step doesn't overflow. Fixes golang#53618 Change-Id: I36e5384d05b4d7168e48db6094200fcae409bfe5 Reviewed-on: https://go-review.googlesource.com/c/go/+/415219 Reviewed-by: Than McIntosh <thanm@google.com> Run-TryBot: David Chase <drchase@google.com> Reviewed-by: David Chase <drchase@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Keith Randall <khr@golang.org> (cherry picked from commit 31b8c23) Reviewed-on: https://go-review.googlesource.com/c/go/+/415414 Reviewed-by: Keith Randall <khr@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
@randall77 requested issue #53600 to be considered for backport to the next 1.18 minor release.
The text was updated successfully, but these errors were encountered: