Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: push does not recognize existing files correctly on windows gomotes on v2 #53593

Closed
cagedmantis opened this issue Jun 28, 2022 · 2 comments
Closed

x/build/cmd/gomote: push does not recognize existing files correctly on windows gomotes on v2 #53593

cagedmantis opened this issue Jun 28, 2022 · 2 comments
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

When issuing repeated push commands without changing any files, all of the files are pushed to the gomote instance:

$ gomote v2 push user-windows-amd64-2016-1
2022/06/28 17:34:13 installing go1.4
2022/06/28 17:34:20 Remote doesn't have "src/cmd/go/internal/modconv/dep.go"
2022/06/28 17:34:20 Remote doesn't have "test/fixedbugs/issue7525b.go"
2022/06/28 17:34:20 Remote doesn't have "src/cmd/go/testdata/script/gopath_std_vendor.txt"
2022/06/28 17:34:20 Remote doesn't have "src/net/http/fs.go"
2022/06/28 17:34:20 Remote doesn't have "test/fixedbugs/issue48916.go"
2022/06/28 17:34:20 Remote doesn't have 11719 files (only showed 5).
2022/06/28 17:34:20 Remote lacks a VERSION file; sending a fake one
2022/06/28 17:34:23 Uploading 11720 new/changed files; 26577343 byte .tar.gz

$ gomote v2 push user-windows-amd64-2016-1
2022/06/28 17:34:50 installing go1.4
2022/06/28 17:34:54 Remote doesn't have "src/cmd/compile/internal/types2/testdata/fixedbugs/issue50276.go"
2022/06/28 17:34:54 Remote doesn't have "test/codegen/smallintiface.go"
2022/06/28 17:34:54 Remote doesn't have "src/cmd/compile/internal/noder/irgen.go"
2022/06/28 17:34:54 Remote doesn't have "src/encoding/json/decode_test.go"
2022/06/28 17:34:54 Remote doesn't have "src/go/doc/comment/testdata/hello.txt"
2022/06/28 17:34:54 Remote doesn't have 11719 files (only showed 5).
2022/06/28 17:34:54 Remote lacks a VERSION file; sending a fake one
2022/06/28 17:34:57 Uploading 11720 new/changed files; 26577343 byte .tar.gz

The expected behavior is that the command would only update the version file.

@golang/release
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jun 28, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Jun 28, 2022
@cagedmantis cagedmantis self-assigned this Jun 28, 2022
@cagedmantis
Copy link
Contributor Author

cc @prattmic

@gopherbot
Copy link

Change https://go.dev/cl/414476 mentions this issue: cmd/gomote: use dirEntry for directory list parsing

@golang golang locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot