Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: miscompilation of value switch involving generic interface types [1.18 backport] #53587

Closed
gopherbot opened this issue Jun 28, 2022 · 2 comments
Closed

cmd/compile: miscompilation of value switch involving generic interface types [1.18 backport] #53587

gopherbot opened this issue Jun 28, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.4

Comments

@gopherbot
Copy link

@mdempsky requested issue #53477 to be considered for backport to the next 1.18 minor release.

@dr2chase I think so.

@gopherbot Please backport to Go 1.18. This is a silent miscompilation of valid Go code.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 28, 2022
@gopherbot gopherbot mentioned this issue Jun 28, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.4 milestone Jun 28, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/414835 mentions this issue: [release-branch.go1.18] cmd/compile: fix generic inter-inter comparisons from value switch statements

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Jun 29, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 29, 2022
@gopherbot
Copy link
Author

Closed by merging f86c6b9 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Jul 6, 2022
@cuonglm @heschi
[release-branch.go1.18] cmd/compile: fix generic inter-inter comparis…
f86c6b9 
…ons from value switch statements

If value is a non-empty interface and has shape, we still need to
convert it to an interface{} first.

Fixes #53587

Change-Id: I516063ba4429a6cc24c483758387ec13815fc63e
Reviewed-on: https://go-review.googlesource.com/c/go/+/414834
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/414835
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 14, 2022
@cuonglm @bradfitz
[release-branch.go1.18] cmd/compile: fix generic inter-inter comparis…
1f53716 
…ons from value switch statements

If value is a non-empty interface and has shape, we still need to
convert it to an interface{} first.

Fixes golang#53587

Change-Id: I516063ba4429a6cc24c483758387ec13815fc63e
Reviewed-on: https://go-review.googlesource.com/c/go/+/414834
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/414835
@golang golang locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.4
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot