Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: failures in maplinear.go with iterdelete: too slow on linux-mips*-rtrk #53574

Open
bcmills opened this issue Jun 27, 2022 · 9 comments
Open
Labels
arch-mips NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 27, 2022

#!watchflakes
post <- pkg == "maplinear.go" && `iterdelete: too slow` && goarch ~ `mips`
##### ../test
# go run run.go -- maplinear.go
exit status 2
panic: iterdelete: too slow: 40000 inserts: 2.755283259s; 80000 inserts: 9.103015471s


goroutine 1 [running]:
panic({0xc7440, 0xc000010030})
	/tmp/gobuilder-mips64/go/src/runtime/panic.go:987 +0x4e0 fp=0xc00006ce88 sp=0xc00006cdd0 pc=0x50670
main.checkLinear({0xd8451, 0xa}, 0x9c4, 0xdfda8)
	/tmp/gobuilder-mips64/go/test/maplinear.go:59 +0x27c fp=0xc00006cf58 sp=0xc00006ce88 pc=0xb9dfc
main.main()
	/tmp/gobuilder-mips64/go/test/maplinear.go:158 +0x25c fp=0xc00006cf80 sp=0xc00006cf58 pc=0xbab4c
runtime.main()
	/tmp/gobuilder-mips64/go/src/runtime/proc.go:250 +0x308 fp=0xc00006cfd8 sp=0xc00006cf80 pc=0x54158
runtime.goexit()
	/tmp/gobuilder-mips64/go/src/runtime/asm_mips64x.s:617 +0x4 fp=0xc00006cfd8 sp=0xc00006cfd8 pc=0x88d7c

greplogs -l -e FAIL\\s+maplinear\\.go
2022-06-21T17:32:57-530511b/linux-mips64-rtrk
2020-02-21T20:59:36-bc5fc6d/linux-mips64-rtrk

Perhaps a good first step would be to double-check whether the test's timing expectations are reasonable for this builder?

(attn @golang/mips; CC @golang/runtime)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-mips labels Jun 27, 2022
@bcmills bcmills added this to the Backlog milestone Jun 27, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jun 28, 2022

Hmm — @bogojevic and @milanknezevic are listed as the maintainers for this builder, but apparently didn't accept the invite to @golang/mips (maybe it got spam-filtered by accident?).

@mengzhuo
Copy link
Contributor

I've contact them, no response too.
CC @wzssyqa

@milanknezevic
Copy link
Contributor

Hello @bcmills, @mengzhuo, sorry for late response. I'm not able to work on maintaining of mips builders because I do not have access to them any more.

@Fearyncess
Copy link

Fearyncess commented Jun 29, 2022

Hello @bcmills, @mengzhuo, sorry for late response. I'm not able to work on maintaining of mips builders because I do not have access to them any more.

@milanknezevic
are you the rtrk's builder provider? will the builders still be working in the future? if not, we (cip united) can provide some mips machines for replacement or add more powerful building machines.

@draganmladjenovic
Copy link

@Fearyncess @bcmills @bcmills I'm currently maintaining these machines in some capacity. They should be working for the foreseeable future, but it is always better to add stronger machines, given that we share the same host for 32-bit and 64-bit MIPS variants.

@bcmills
Copy link
Contributor Author

bcmills commented Jun 29, 2022

@draganmladjenovic, could you send a change to update x/build/dashboard (and perhaps x/build/internal/gophers) with current contact information for the rtrk machines?

@bcmills
Copy link
Contributor Author

bcmills commented Jul 1, 2022

Also mipsle (not just mips64).

greplogs -l -e FAIL\\s+maplinear\\.go --since=2022-06-22
2022-06-30T21:52:06-af725f4/linux-mipsle-rtrk

@bcmills bcmills changed the title test: failures in maplinear.go with iterdelete: too slow on linux-mips64-rtrk test: failures in maplinear.go with iterdelete: too slow on linux-mips*-rtrk Jul 1, 2022
@gopherbot
Copy link

Change https://go.dev/cl/415715 mentions this issue: dashboard: update host-linux-mips64*-rtrk owner

gopherbot pushed a commit to golang/build that referenced this issue Jul 6, 2022
Updates golang/go#53574.

Change-Id: Ia9c74b1c97a96382c236b0b49b26dda51be0ad8a
Reviewed-on: https://go-review.googlesource.com/c/build/+/415715
Reviewed-by: Meng Zhuo <mzh@golangcn.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "maplinear.go" && `iterdelete: too slow` && goarch ~ `mips`
2023-02-02 23:40 linux-mips-rtrk go@683b2c46 maplinear.go (log)
# go run run.go -- maplinear.go
exit status 2
panic: iterdelete: too slow: 40000 inserts: 1.629930923s; 80000 inserts: 6.155884559s


goroutine 1 [running]:
panic({0xc8660, 0x40c060})
	/tmp/gobuilder-mips64/go/src/runtime/panic.go:1015 +0x528 fp=0x45ef3c sp=0x45eedc pc=0x50b48
main.checkLinear({0xd4942, 0xa}, 0x9c4, 0xdbf2c)
	/tmp/gobuilder-mips64/go/test/maplinear.go:59 +0x2bc fp=0x45efac sp=0x45ef3c pc=0xba76c
main.main()
	/tmp/gobuilder-mips64/go/test/maplinear.go:158 +0x210 fp=0x45efc0 sp=0x45efac pc=0xbaa50
runtime.main()
	/tmp/gobuilder-mips64/go/src/runtime/proc.go:250 +0x2b0 fp=0x45efec sp=0x45efc0 pc=0x54770
runtime.goexit()
	/tmp/gobuilder-mips64/go/src/runtime/asm_mipsx.s:617 +0x4 fp=0x45efec sp=0x45efec pc=0x8aa58

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-mips NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

7 participants