Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: support fake time #5356

Closed
adg opened this issue Apr 26, 2013 · 9 comments
Closed

runtime: support fake time #5356

adg opened this issue Apr 26, 2013 · 9 comments

Comments

@adg
Copy link
Contributor

adg commented Apr 26, 2013

Perhaps there should be a compile time flag for the runtime to support faking time.
(Zero-length sleeps that advance a synthetic clock.)
@dvyukov
Copy link
Member

dvyukov commented Apr 26, 2013

Comment 1:

I would prefer a constant in runtime.h that you need switch manually.
FTR, here are the changelists:
https://golang.org/cl/8795047/
https://golang.org/cl/8891044/

@kylelemons
Copy link
Contributor

Comment 2:

It seems like it could be really useful to have the fake time available when building
test binaries.

@dvyukov
Copy link
Member

dvyukov commented Apr 26, 2013

Comment 3:

The fake time that we mean here is not "mockable", that is, you can not control it from
the test code. If you mean that.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 4:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 6:

Labels changed: added repo-main.

@adg
Copy link
Contributor Author

adg commented Jun 20, 2014

Comment 7:

This did exist in the runtime but has since been hacked out.
This is blocking the deployment of Go 1.3 to the playground. :-/

@gopherbot
Copy link

Comment 8:

CL https://golang.org/cl/101400043 mentions this issue.

@minux
Copy link
Member

minux commented Oct 28, 2014

Comment 9:

This issue was closed by revision 2fe9482.

Status changed to Fixed.

@adg adg added fixed labels Oct 28, 2014
@adg adg self-assigned this Oct 28, 2014
@golang golang locked and limited conversation to collaborators Jun 24, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Revived from CL 15690048.

Fixes golang#5356.

LGTM=rsc
R=adg, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/101400043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
Revived from CL 15690048.

Fixes golang#5356.

LGTM=rsc
R=adg, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/101400043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
Revived from CL 15690048.

Fixes golang#5356.

LGTM=rsc
R=adg, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/101400043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018
Revived from CL 15690048.

Fixes golang#5356.

LGTM=rsc
R=adg, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/101400043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
Revived from CL 15690048.

Fixes golang#5356.

LGTM=rsc
R=adg, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/101400043
@rsc rsc unassigned adg Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants