Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/internal/boring: move boring.Cache to a separate package #53515

Closed
qmuntal opened this issue Jun 23, 2022 · 4 comments
Closed

crypto/internal/boring: move boring.Cache to a separate package #53515

qmuntal opened this issue Jun 23, 2022 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.19

Comments

@qmuntal
Copy link
Contributor

qmuntal commented Jun 23, 2022

Cl 395882 added a GC-friendly runtime-backed concurrent map to the boring package which is being used in several crypto packages.

We (Microsoft) are patching Go to add support for OpenSSL as crypto backend at microsoft/go (github.com), and it would be convenient for us, and also for other companies which forked Go for the same purpose, to be able to use crypto/internal/boring.Cache without importing the whole boring package.

It worth nothing that we could also implement boring.Cache in our fork, but that would also mean patching runtime/mgc.go, which I would like to avoid in order to reduce conflict likeliness.

Would it be possible to move crypto/internal/boring/cache.go to a new package, i.e., crypto/internal/boring/cache.

@rsc @FiloSottile
@ianlancetaylor
Copy link
Contributor

Would this be satisfied by https://go.dev/cl/407135 ? That change is approved but not yet submitted.

@qmuntal
Copy link
Contributor Author

qmuntal commented Jun 23, 2022 •
edited

Would this be satisfied by https://go.dev/cl/407135 ? That change is approved but not yet submitted.

This is exactly what I was asking for, thanks!

@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 24, 2022
@cagedmantis cagedmantis added this to the Backlog milestone Jun 24, 2022
@qmuntal
Copy link
Contributor Author

qmuntal commented Jun 27, 2022

https://go.dev/cl/407135 has been merged, so closing this issue.

@cagedmantis could you label this issue as go1.19 and remove Backlog?

@qmuntal qmuntal closed this as completed Jun 27, 2022
@rsc rsc modified the milestones: Backlog, Go1.19 Jun 27, 2022
@rsc
Copy link
Contributor

rsc commented Jun 27, 2022

Updated the milestone, although we don't usually try to maintain milestone for closed issues.

@golang golang locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
5 participants
@rsc @cagedmantis @ianlancetaylor @qmuntal @gopherbot