Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: net/http: canceling BaseContext should trigger graceful shutdown #53487

Closed
iangudger opened this issue Jun 21, 2022 · 1 comment
Closed

proposal: net/http: canceling BaseContext should trigger graceful shutdown #53487

iangudger opened this issue Jun 21, 2022 · 1 comment
Labels
FrozenDueToAge Proposal
Milestone
Proposal

Comments

@iangudger
Copy link
Contributor

It doesn't make much sense to keep accepting requests only to handle them with an invalid context.
@gopherbot gopherbot added this to the Proposal milestone Jun 21, 2022
@seankhliao
Copy link
Member

BaseContext is a function that can return a dynamically generated context, there's no guarantee that once a cancelled context is seen, future ones will also be cancelled

see also #52805

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2022
@golang golang locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal
Projects
None yet
Milestone
Proposal
Development

No branches or pull requests
3 participants
@iangudger @gopherbot @seankhliao