Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: internal compiler error: width not calculated: int128 [1.17 backport] #53470

Closed
gopherbot opened this issue Jun 21, 2022 · 2 comments
Closed

cmd/compile: internal compiler error: width not calculated: int128 [1.17 backport] #53470

gopherbot opened this issue Jun 21, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.12

Comments

@gopherbot
Copy link

@randall77 requested issue #53454 to be considered for backport to the next 1.17 minor release.

@gopherbot please open a backport to 1.17 and 1.18.

This bug causes an ICE in rare circumstances.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 21, 2022
@gopherbot gopherbot mentioned this issue Jun 21, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.12 milestone Jun 21, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/413456 mentions this issue: [release-branch.go1.17] cmd/compile: allow 128-bit values to be spilled

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Jun 29, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 29, 2022
@gopherbot
Copy link
Author

Closed by merging 9ef614f to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Jul 6, 2022
@randall77 @heschi
[release-branch.go1.17] cmd/compile: allow 128-bit values to be spilled
9ef614f 
We sometimes use 16-byte load+store to move values around in memory.
In rare circumstances, the loaded value must be spilled because the
store can't happen yet.

In that case, we need to be able to spill the 16-byte value.

Fixes #53470

Change-Id: I09fd08e11a63c6ba3ef781d3f5ede237e9b0132e
Reviewed-on: https://go-review.googlesource.com/c/go/+/413294
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
(cherry picked from commit c2d373d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/413456
Reviewed-by: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.12
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot