all: add freebsd/riscv64 port #53466

dmgk · 2022-06-20T18:58:39Z

This issue is intended to serve both as a proposal and to track the progress of adding the freebsd/riscv64 port.

The majority of porting work is done, there's an out-of-tree port at https://github.com/MikaelUrankar/go/tree/freebsd_riscv64 which builds and passes all run.bash tests, including cgo (tested under QEMU and on Unmatched).

@mengzhuo has graciously agreed to setup and maintain the freebsd/riscv64 builder (on SiFive Unmatched) and @MikaelUrankar has agreed to be the port maintainer.

cc @golang/freebsd @golang/riscv64 @mengzhuo @MikaelUrankar

The text was updated successfully, but these errors were encountered:

mengzhuo · 2022-06-22T01:02:29Z

CC @rsc

rsc · 2022-06-22T18:08:49Z

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

mengzhuo · 2022-06-27T01:37:13Z

I tried to install the prometheus node_exporter and got undefined errors from golang.org/x/sys

I think we should update golang.org/x/sys and other x/ moduels first and leave alone the Go main develope cycle.

paulzhol · 2022-06-27T07:16:44Z

I'm already updating golang.org/x/sys as part of #53280. It is indeed horribly out of date. For example Time_t on freebsd/arm is still 32-bit. It was switched to 64-bit more than 16 years ago (I guess it originates directly from the syscall package).
There ptrace constants which are defined only on the x86 arches, not available on both ARMs (because these were probably not generated on actual hosts).
I shudder to think of what state the golang.org/x/net/route is in. std still carries a hand copied if_data8 and if_msghdr8 types.

rsc · 2022-06-29T17:15:05Z

The new port policy (#53383) will require two maintainers for the port. Assuming that is accepted, is there anyone else who would be willing to be a second maintainer for freebsd/riscv64?

dmgk · 2022-07-01T12:11:44Z

Assuming nobody else volunteers, I'll be willing to be a second maintainer for the freebsd/riscv64 (can we have more than two?). I think more people will be interested when this port is closer to be merged.

mengzhuo · 2022-07-01T14:35:35Z

I want to be the third maintainer since the freebsd/riscv64 stage0 is up and ready.

gopherbot · 2022-07-11T07:47:28Z

Change https://go.dev/cl/416834 mentions this issue: unix: add freebsd/riscv64 support

For golang/go#53466 Change-Id: If5a4dc674cb1856ac580fb87d8030d50fa7c95dd Reviewed-on: https://go-review.googlesource.com/c/sys/+/416834 Reviewed-by: Benny Siegert <bsiegert@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org> Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com> Reviewed-by: Dmitri Goutnik <dgoutnik@gmail.com>

rsc · 2022-07-13T17:19:01Z

Thanks to @MikaelUrankar, @dmgk, and @mengzhuo for volunteering to be maintainers.

rsc · 2022-07-13T18:41:14Z

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

rsc · 2022-07-20T18:03:48Z

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

gopherbot · 2022-07-21T16:06:20Z

Change https://go.dev/cl/418814 mentions this issue: all: add FreeBSD riscv64 support

dmitshur · 2022-08-08T15:26:44Z

CC @golang/release.

For golang/go#53466 Change-Id: Ibbeab43923bdd6b455a28c627832e676b401b4f4 Reviewed-on: https://go-review.googlesource.com/c/net/+/418814 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Dmitri Goutnik <dgoutnik@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org>

gopherbot · 2022-08-26T19:45:53Z

Change https://go.dev/cl/425937 mentions this issue: build/dashboard: add freebsd-riscv64

paulzhol · 2022-10-13T18:49:39Z

Thanks @dmgk! Makes sense.

gopherbot · 2022-10-14T11:37:11Z

Change https://go.dev/cl/443036 mentions this issue: runtime: Add vdso on freebsd/riscv64

If no external linker was passed with -extld, link currently assumes that it is "gcc" which is not correct for platforms that use clang toolchain. Return "clang" for platforms that use it, this fixes dir tests on freebsd/riscv64. For #53466 Change-Id: Ie3bce1b9581839d0b3b2129908355cd30ae9a713 Reviewed-on: https://go-review.googlesource.com/c/go/+/432756 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Joel Sing <joel@sing.id.au> Reviewed-by: Mikaël Urankar <mikael.urankar@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Joedian Reid <joedian@golang.org>

gopherbot · 2022-10-18T07:46:35Z

Change https://go.dev/cl/443496 mentions this issue: dashboard: drop known issue for freebsd-riscv64

mengzhuo · 2022-10-18T12:44:22Z

I've droped CC env and it looks at Go repo after 15e2669, however there are some breaks in sub repos:

benchmarks, crypto, debug, website need to update sys
https://build.golang.org/log/53ce3f76b6022e63ff2125b926d7624dcddeec19

text:
https://build.golang.org/log/53ce3f76b6022e63ff2125b926d7624dcddeec19

paulzhol · 2022-10-18T14:29:00Z

Could this be due to the LANG=C.UTF-8/MM_CHARSET=UTF-8 envs (but maybe with a missing /usr/share/locale/NNNN on the host)?
I do see them on freebsd/arm as well, but I explicitly had to add UTF-8 to the nanobsd build.

paulzhol · 2022-10-18T14:40:29Z

Scratch that, it looks specific to risc-v? starting from http://golang.org/cl/442796:
linux-riscv64-unmatched
https://build.golang.org/log/20584668bb2c87ad76afd348278e21fbc0686ef0

heschi · 2022-10-18T16:30:04Z

re: sys updates, I happen to be working on that this week.

dmgk · 2022-10-18T20:09:45Z

Something between 4fe1971 and ddc7d2a broke x/text on riscv64. af668c6 looks relevant, I'll do git bisect but it will take some time with QEMU.

mengzhuo · 2022-10-20T11:30:47Z

NOTE: This builder will be unavailable due to kernel panic, I will try to reboot it everyday if it's down.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267225

dmgk · 2022-10-20T11:43:09Z

@mengzhuo Thanks for reporting this. We may need to update the builder to 13.1-STABLE later when this panic is fixed.

Use rdtime to retrieve the timecounter, same as the FreeBSD libc. Updates #53466 Change-Id: I48816e9100036f1ef483e4d3afcf10db0d3b85f8 Reviewed-on: https://go-review.googlesource.com/c/go/+/443036 Reviewed-by: Meng Zhuo <mzh@golangcn.org> Reviewed-by: Dmitri Goutnik <dgoutnik@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org>

gopherbot · 2022-10-30T13:13:47Z

Change https://go.dev/cl/446515 mentions this issue: all: update sys to 0.1.0

gopherbot · 2022-10-31T01:49:55Z

Change https://go.dev/cl/446516 mentions this issue: all: update golang.org/x/sys to v0.1.0

This CL update golang.org/x/sys to 0.1.0 for FreeBSD/riscv64 porting For golang/go#53466 Change-Id: I6cbfced0c9e1abef735ea3d8ea5ae1b9971c2e45 Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/446516 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Meng Zhuo <mzh@golangcn.org>

This CL update golang.org/x/sys to 0.1.0 for FreeBSD/riscv64 porting For golang/go#53466 Change-Id: I56c920d17c0d6a08cf89c927fa840c55a59d6e83 Reviewed-on: https://go-review.googlesource.com/c/debug/+/446515 Auto-Submit: Ian Lance Taylor <iant@google.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>

If no external linker was passed with -extld, link currently assumes that it is "gcc" which is not correct for platforms that use clang toolchain. Return "clang" for platforms that use it, this fixes dir tests on freebsd/riscv64. For golang#53466 Change-Id: Ie3bce1b9581839d0b3b2129908355cd30ae9a713 Reviewed-on: https://go-review.googlesource.com/c/go/+/432756 Run-TryBot: Cherry Mui <cherryyz@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Joel Sing <joel@sing.id.au> Reviewed-by: Mikaël Urankar <mikael.urankar@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Joedian Reid <joedian@golang.org>

Use rdtime to retrieve the timecounter, same as the FreeBSD libc. Updates golang#53466 Change-Id: I48816e9100036f1ef483e4d3afcf10db0d3b85f8 Reviewed-on: https://go-review.googlesource.com/c/go/+/443036 Reviewed-by: Meng Zhuo <mzh@golangcn.org> Reviewed-by: Dmitri Goutnik <dgoutnik@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org>

The FreeBSD riscv64 builder passed all tests after CL432756 merged. We can drop known issue now. For golang/go#53466 Change-Id: Ia9f63b2eb780fbb39fbaf684045b7f8b46101a93 Reviewed-on: https://go-review.googlesource.com/c/build/+/443496 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Goutnik <dgoutnik@gmail.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>

For golang/go#53466 Change-Id: Ibbeab43923bdd6b455a28c627832e676b401b4f4 Reviewed-on: https://go-review.googlesource.com/c/net/+/418814 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Dmitri Goutnik <dgoutnik@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Meng Zhuo <mzh@golangcn.org>

gopherbot · 2022-11-21T01:36:58Z

Change https://go.dev/cl/452355 mentions this issue: all: update golang.org/x/net to v0.2.0

gopherbot · 2022-12-09T19:10:21Z

Change https://go.dev/cl/456575 mentions this issue: dashbord: restrict freebsd-riscv64-unmatched to the same repos as linux-riscv64-unmatched

…ux-riscv64-unmatched Fixes golang/go#56273. Updates golang/go#53466. Change-Id: I6e796006f8f7120ae05d5e62cdbc7cdd9d146f7e Reviewed-on: https://go-review.googlesource.com/c/build/+/456575 Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Run-TryBot: Bryan Mills <bcmills@google.com>

dmitshur · 2022-12-09T23:49:12Z

The proposal is approved, the port is listed in go tool dist list, has a passing builder, and is mentioned in 1.20 release notes draft. Thanks and congrats on getting to this point!

Is there more that should be done here before closing this issue, or shall we do that now? (New issues can be opened to track specific known work to improve the port.)

dmgk · 2022-12-12T22:43:52Z

I think this issue can be closed. Thanks everyone for working on it.

dmgk added the Proposal label Jun 20, 2022

mengzhuo added OS-FreeBSD arch-riscv Issues solely affecting the riscv64 architecture. labels Jun 21, 2022

ianlancetaylor changed the title ~~all: add freebsd/riscv64 port~~ proposal: all: add freebsd/riscv64 port Jun 22, 2022

gopherbot added this to the Proposal milestone Jun 22, 2022

ianlancetaylor added this to Incoming in Proposals (old) Jun 22, 2022

rsc moved this from Incoming to Active in Proposals (old) Jun 22, 2022

rsc moved this from Active to Likely Accept in Proposals (old) Jul 13, 2022

rsc added the Proposal-FinalCommentPeriod label Jul 13, 2022

rsc moved this from Likely Accept to Accepted in Proposals (old) Jul 20, 2022

rsc changed the title ~~proposal: all: add freebsd/riscv64 port~~ all: add freebsd/riscv64 port Jul 20, 2022

rsc added the Proposal-Accepted label Jul 20, 2022

rsc modified the milestones: Proposal, Backlog Jul 20, 2022

dmgk mentioned this issue Oct 14, 2022

access: add new member to the golang/freebsd group #56226

Closed

mengzhuo mentioned this issue Oct 24, 2022

x/build/dashboard: freebsd-riscv64-unmatched misconfigured to run on unsupported release branches #56273

Closed

dmgk closed this as completed Dec 12, 2022

golang locked and limited conversation to collaborators Dec 12, 2023

gopherbot added the FrozenDueToAge label Dec 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: add freebsd/riscv64 port #53466

all: add freebsd/riscv64 port #53466

dmgk commented Jun 20, 2022 •

edited

mengzhuo commented Jun 22, 2022 •

edited

rsc commented Jun 22, 2022

mengzhuo commented Jun 27, 2022 •

edited

paulzhol commented Jun 27, 2022

rsc commented Jun 29, 2022

dmgk commented Jul 1, 2022

mengzhuo commented Jul 1, 2022 •

edited

gopherbot commented Jul 11, 2022

rsc commented Jul 13, 2022

rsc commented Jul 13, 2022

rsc commented Jul 20, 2022

gopherbot commented Jul 21, 2022

dmitshur commented Aug 8, 2022

gopherbot commented Aug 26, 2022

paulzhol commented Oct 13, 2022

gopherbot commented Oct 14, 2022

gopherbot commented Oct 18, 2022

mengzhuo commented Oct 18, 2022

paulzhol commented Oct 18, 2022

paulzhol commented Oct 18, 2022

heschi commented Oct 18, 2022

dmgk commented Oct 18, 2022

mengzhuo commented Oct 20, 2022

dmgk commented Oct 20, 2022

gopherbot commented Oct 30, 2022

gopherbot commented Oct 31, 2022

gopherbot commented Nov 21, 2022

gopherbot commented Dec 9, 2022

dmitshur commented Dec 9, 2022

dmgk commented Dec 12, 2022

all: add freebsd/riscv64 port #53466

all: add freebsd/riscv64 port #53466

Comments

dmgk commented Jun 20, 2022 • edited

mengzhuo commented Jun 22, 2022 • edited

rsc commented Jun 22, 2022

mengzhuo commented Jun 27, 2022 • edited

paulzhol commented Jun 27, 2022

rsc commented Jun 29, 2022

dmgk commented Jul 1, 2022

mengzhuo commented Jul 1, 2022 • edited

gopherbot commented Jul 11, 2022

rsc commented Jul 13, 2022

rsc commented Jul 13, 2022

rsc commented Jul 20, 2022

gopherbot commented Jul 21, 2022

dmitshur commented Aug 8, 2022

gopherbot commented Aug 26, 2022

paulzhol commented Oct 13, 2022

gopherbot commented Oct 14, 2022

gopherbot commented Oct 18, 2022

mengzhuo commented Oct 18, 2022

paulzhol commented Oct 18, 2022

paulzhol commented Oct 18, 2022

heschi commented Oct 18, 2022

dmgk commented Oct 18, 2022

mengzhuo commented Oct 20, 2022

dmgk commented Oct 20, 2022

gopherbot commented Oct 30, 2022

gopherbot commented Oct 31, 2022

gopherbot commented Nov 21, 2022

gopherbot commented Dec 9, 2022

dmitshur commented Dec 9, 2022

dmgk commented Dec 12, 2022

dmgk commented Jun 20, 2022 •

edited

mengzhuo commented Jun 22, 2022 •

edited

mengzhuo commented Jun 27, 2022 •

edited

mengzhuo commented Jul 1, 2022 •

edited