Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go1.19beta1 fails whenever it sees an Emacs lock file #53421

Closed
bradfitz opened this issue Jun 17, 2022 · 2 comments
Closed

cmd/go: go1.19beta1 fails whenever it sees an Emacs lock file #53421

bradfitz opened this issue Jun 17, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@bradfitz
Copy link
Contributor

go1.19beta1 is nearly unusable with a default Emacs config. (Not looking for Emacs or git clean help)

Go 1.18.3 runs tests fine:

bradfitz@tsdev:~/src/tailscale.com/util/deephash$ ~/go/bin/go1.18.3 test 
PASS
ok      tailscale.com/util/deephash     0.441s

But Go 1.19beta1 fails to run the tests in the util/deephash directory because of an Emacs lock file (a dangling symlink):

bradfitz@tsdev:~/src/tailscale.com/util/deephash$ ~/go/bin/go1.19beta1 test 
stat /home/bradfitz/src/tailscale.com/cmd/tailscaled/.#tailscaled.go: no such file or directory
bradfitz@tsdev:~/src/tailscale.com/util/deephash$ ls -l /home/bradfitz/src/tailscale.com/cmd/tailscaled/.#tailscaled.go
lrwxrwxrwx 1 bradfitz bradfitz 33 Jun 15 14:51 /home/bradfitz/src/tailscale.com/cmd/tailscaled/.#tailscaled.go -> bradfitz@tsdev.1002020:1653778856

Particularly offensive is that the symlink isn't even in the package I'm testing, and isn't even a transitive dep of the package being tested:

bradfitz@tsdev:~/src/tailscale.com/util/deephash$ go list -f {{.Deps}} . | grep tailscaled | wc -l
0

Okay, let's delete that file and carry on:

bradfitz@tsdev:~/src/tailscale.com/util/deephash$ rm /home/bradfitz/src/tailscale.com/cmd/tailscaled/.#tailscaled.go
bradfitz@tsdev:~/src/tailscale.com/util/deephash$ ~/go/bin/go1.19beta1 test 
stat /home/bradfitz/src/tailscale.com/net/netstat/.#tcptable_windows.go: no such file or directory
bradfitz@tsdev:~/src/tailscale.com/util/deephash$ ls -l /home/bradfitz/src/tailscale.com/net/netstat/.#tcptable_windows.go
lrwxrwxrwx 1 bradfitz bradfitz 30 Sep 10  2020 /home/bradfitz/src/tailscale.com/net/netstat/.#tcptable_windows.go -> bradfitz@tsdev.6860:1592416003
bradfitz@tsdev:~/src/tailscale.com/util/deephash$ rm /home/bradfitz/src/tailscale.com/net/netstat/.#tcptable_windows.go
bradfitz@tsdev:~/src/tailscale.com/util/deephash$ ~/go/bin/go1.19beta1 test 
stat /home/bradfitz/src/tailscale.com/tsnet/.#tslib.go: no such file or directory

more, more, more.

I see nothing in https://tip.golang.org/doc/go1.19 talking about this new behavior if it's intentional and I see no open issues about this, so I'm assuming it's not a known feature or bug.

@seankhliao
Copy link
Member

maybe #53387 ?

@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 17, 2022
@bradfitz
Copy link
Contributor Author

@seankhliao, thanks! Yup, that looks like the same. Closing this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

4 participants