Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv6: TestPacketConnReadWriteUnicastUDP failure with sendmsg: no buffer space available on darwin/amd64 #53402

Closed
bcmills opened this issue Jun 15, 2022 · 1 comment
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 15, 2022

--- FAIL: TestPacketConnReadWriteUnicastUDP (0.00s)
    unicast_test.go:63: write udp [::1]:61587->[::1]:61587: sendmsg: no buffer space available
FAIL
FAIL	golang.org/x/net/ipv6	0.170s

greplogs -l -e 'FAIL: TestPacketConnReadWriteUnicastUDP .*(?:\n .*)* sendmsg: no buffer space available'
2022-06-13T16:53:11-c690dde-7eeec1f/darwin-amd64-12_0
2022-01-06T19:21:12-5b0dc2d-ed84a83/darwin-amd64-10_14

Previously: #37319, #50455, #51342, #52549. (CC @ianlancetaylor)

I expect this fix will be similar. This test boilerplate has sure been copied a lot of times... 😩

@gopherbot gopherbot added this to the Unreleased milestone Jun 15, 2022
@bcmills bcmills added OS-Darwin NeedsFix The path to resolution is known, but the work has not been done. labels Jun 15, 2022
@bcmills bcmills self-assigned this Jul 8, 2022
@gopherbot
Copy link

Change https://go.dev/cl/416556 mentions this issue: ipv4,ipv6: retry ENOBUFS in TestPacketConnReadWriteUnicastUDP

@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 8, 2022
WeiminShang added a commit to WeiminShang/net that referenced this issue Nov 16, 2022
This ports CL 402059 to the non-concurrent UDP and ICMP variants of
the test.

(It isn't obvious to me whether the ENOBUFS retry loop is strictly
needed for the ICMP variants, but I'm getting kind of tired of porting
this CL to different tests and would rather minimize the number of
times it has to be done again. 😩)

Fixes golang/go#53402.

Change-Id: I8dc385fbce121c364efafd988ccf08eebe3fef28
Reviewed-on: https://go-review.googlesource.com/c/net/+/416556
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@golang golang locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants