Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: script test hanging with blocked output pipes #53400

Closed
bcmills opened this issue Jun 15, 2022 · 2 comments
Closed

cmd/go: script test hanging with blocked output pipes #53400

bcmills opened this issue Jun 15, 2022 · 2 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.20

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 15, 2022

greplogs -l -e 'goroutine \d+ \[chan receive, \d+ minutes\]:\n(?:.+\n\t.+\n)*cmd/go_test\.waitOrStop' --since=2022-01-01
2022-06-06T15:42:19-47e34ca/windows-amd64-longtest
2022-05-26T22:25:23-55c42c2/windows-amd64-longtest
2022-05-20T23:37:43-0a1a092/linux-amd64-longtest
2022-05-20T23:37:43-0a1a092/windows-amd64-longtest
2022-05-20T23:05:38-c3470ca/linux-amd64-longtest
2022-05-20T23:05:38-c3470ca/windows-amd64-longtest
2022-05-20T22:30:37-2b0e457/linux-amd64-longtest
2022-05-20T22:30:37-2b0e457/windows-amd64-longtest
2022-05-20T21:54:20-b580670/linux-amd64-longtest
2022-05-20T21:54:20-b580670/windows-amd64-longtest
2022-05-20T21:32:57-7ec6ef4/linux-amd64-longtest
2022-05-20T21:32:57-7ec6ef4/windows-amd64-longtest
2022-02-03T22:55:24-248ad85/netbsd-amd64-9_0
@bcmills bcmills added this to the Go1.20 milestone Jun 15, 2022
@bcmills bcmills self-assigned this Jun 15, 2022
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 15, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jun 15, 2022

This is some script test hanging while waiting on the subprocess's output pipes to close, with the output pipes stuck open.

This is quite possibly a bug in the go command, but it will be much more straightforward to diagnose once #50436 is implemented. (A workaround in the interim is possible but more complex, because we would either have to run our own pipe-copying goroutines or direct all of the stderr and stdout output pipes for script tests to files.)

I plan to implement #50436 for Go 1.20, so milestoning to Go 1.20.

@bcmills bcmills mentioned this issue Jul 7, 2022
Closed
@bcmills bcmills mentioned this issue Aug 16, 2022
Open
@bcmills
Copy link
Contributor Author

bcmills commented Sep 21, 2022

Duplicate of #50187.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
@golang golang locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
2 participants
@bcmills @gopherbot