-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: decide status of Android TryBots #53377
Comments
Change https://go.dev/cl/412174 mentions this issue: |
Change https://go.dev/cl/407615 mentions this issue: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Issue golang/go#42212 manifests as test timeouts, and is by far the most frequent of these known issues. Issue golang/go#51001 causes failures with "systemstack called from unexpected goroutine". It seems to have been introduced sometime last year, but it isn't clear to me whether it is a regression or an older (latent) bug unearthed by some other change. Issue golang/go#52724 appears to be a bug or race in the Android emulator itself. It might require a builder image update and/or escalation to the maintainers of the emulator proper. Updates golang/go#53377. Change-Id: I677915b1ff02dd02e0f14c63b0d25caf11e27a72 Reviewed-on: https://go-review.googlesource.com/c/build/+/412174 Reviewed-by: David Chase <drchase@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Bryan Mills <bcmills@google.com>
We think that this should be removed from the TryBot set: it's pretty noisy and there isn't a clear path to fixing it. If nobody disagrees we'll do that. cc @eliasnaur, who may be interested |
I think in the current state it makes sense for the If I understand correctly, @cherrymui may support that too, based on this comment on CL 407615. (I'll update that CL once this issue moves to NeedsFix state.) |
Just clarify questions: |
Yes, this is correct. "Removing the builder from the TryBot set" would mean it will not run automatically before CL submission when Run-TryBot+1 vote is set, but can be requested via SlowBots syntax (i.e., I think this answers other questions, but let me know if I missed something. (I didn't quite understand what "a proper upgrade" refers to in the last question.) |
The
android-amd64-emu
builder currently runs as a TryBot in the default set. However,android/amd64
is not a first-class port, and has some open issues that can cause test failures in TryBot runs (notably #51001, #52724, #42212).Discussion #53060 proposes to run only first-class ports as TryBots, but I think we should reevaluate the status of
android
TryBot in particular independent of that discussion, because we have specific known failure modes affecting theandroid
TryBot today.CL 407615 would remove this TryBot for the
go
repo, and #25963 discussesmisc-compile
TryBots that could plausibly take its place.In order to avoid TryBot failure noise when the tree reopens for Go 1.20, we should decide on the status of this TryBot (and update
cmd/coordinator
accordingly) before completing the Go 1.19 release cycle.(CC @eliben @golang/android @golang/release)
The text was updated successfully, but these errors were encountered: