Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportReuseConnection_Gzip_.* failures with "didn't reuse connection" #53373

Closed
bcmills opened this issue Jun 14, 2022 · 10 comments
Closed

net/http: TestTransportReuseConnection_Gzip_.* failures with "didn't reuse connection" #53373

bcmills opened this issue Jun 14, 2022 · 10 comments
Assignees
@neild
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 14, 2022 •
edited 

#!watchflakes
post <- pkg == "net/http" && test ~ `TestTransportReuseConnection_Gzip_.*` && `didn.t reuse connection` && date < "2023-08-30"

2022/06/08 19:53:00 http: TLS handshake error from 127.0.0.1:21458: EOF
--- FAIL: TestTransportReuseConnection_Gzip_ContentLength (0.10s)
    transport_test.go:4447: didn't reuse connection
FAIL
FAIL	net/http	11.607s

greplogs -l -e 'FAIL: TestTransportReuseConnection.*(?:\n .*)* didn'\''t reuse connection' --since=2022-01-01
2022-06-08T19:41:54-bdde41e/freebsd-amd64-race

See previously #22212.

Perhaps a good first step would be to modify the test to use net/http/httptrace to dump more information about what's going on with the connections?

(CC @neild @golang/freebsd)
@bcmills bcmills added help wanted OS-FreeBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 14, 2022
@bcmills bcmills added this to the Backlog milestone Jun 14, 2022
@ayang64
Copy link
Member

ayang64 commented Jun 14, 2022

if noone else does, i'll take a look this afternoon. assigning to myself as a reminder.

@ayang64 ayang64 self-assigned this Jun 14, 2022
@ayang64
Copy link
Member

ayang64 commented Jun 16, 2022 •
edited

i can't reproduce; will try to set up the same environment: OS Version: FreeBSD 13.0-STABLE FreeBSD 13.0-STABLE #0 stable/13-n248759-3684bb89d52

@bcmills
Copy link
Contributor Author

bcmills commented Jun 16, 2022

@ayang64, given that there is only one of these in the logs, this looks to me to be a very rare failure. I would not expect it to reproduce easily.

(That's why I suggest starting by modifying the test to dump more information — since this failure mode is so rare, ideally we should extract as much information as we can should it occur again.)

@bcmills bcmills changed the title net/http: TestTransportReuseConnection_Gzip_ContentLength failure with "didn't reuse connection" on freebsd-amd64-race net/http: TestTransportReuseConnection_Gzip_.* failures with "didn't reuse connection" Aug 22, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Aug 22, 2022

This does not appear to be freebsd-specific:
greplogs -l -e 'FAIL: TestTransportReuseConnection_.*\n\s.*didn.t reuse connection' --since=2022-01-01
2022-08-16T16:27:35-a45bbea/darwin-amd64-nocgo
2022-08-12T16:38:52-f001df5/windows-arm64-11
2022-06-08T19:41:54-bdde41e/freebsd-amd64-race

Note that darwin/amd64 is a first-class builder (attn @neild).

@bcmills bcmills assigned neild and unassigned ayang64 Aug 22, 2022
@bcmills bcmills mentioned this issue Aug 22, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/432375 mentions this issue: net/http: add tracing to TestTransportReuseConnection_Gzip_*

gopherbot pushed a commit that referenced this issue Sep 21, 2022
@neild
net/http: add tracing to TestTransportReuseConnection_Gzip_*
4412230 
These tests are flaky; add some additional logging in hopes
it will aid in debugging.

For #53373

Change-Id: I971a2815f50932a9700ef8c2f684c5416951e6de
Reviewed-on: https://go-review.googlesource.com/c/go/+/432375
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@neild
Copy link
Contributor

neild commented Sep 28, 2022

Added a watchflakes stanza to the issue description.

@neild neild removed their assignment Sep 28, 2022
@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test ~ `TestTransportReuseConnection_Gzip_.*`
2022-08-16 16:27 darwin-amd64-nocgo go@a45bbeae net/http.TestTransportReuseConnection_Gzip_Chunked (log) 
--- FAIL: TestTransportReuseConnection_Gzip_Chunked (0.09s)
    transport_test.go:4447: didn't reuse connection

— watchflakes

@neild
Copy link
Contributor

neild commented Nov 18, 2022

(Still waiting for a flake with the additional tracing; the one at a45bbea predates the tracing.)

@bcmills bcmills mentioned this issue Jan 6, 2023
Closed
@gopherbot

This comment was marked as off-topic.

Sign in to view
@bcmills
Copy link
Contributor Author

bcmills commented Aug 30, 2023

I suspect this was fixed by https://go.dev/cl/483116. Closing as “probably fixed”, and watchflakes can file a new issue for it if I'm wrong.

@bcmills bcmills closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
Backlog
Development

No branches or pull requests
4 participants
@neild @ayang64 @bcmills @gopherbot