Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: type assertion on generic type fails incorrectly [1.18 backport] #53357

Closed
gopherbot opened this issue Jun 13, 2022 · 4 comments
Closed

cmd/compile: type assertion on generic type fails incorrectly [1.18 backport] #53357

gopherbot opened this issue Jun 13, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.18.4

Comments

@gopherbot
Copy link

@randall77 requested issue #53309 to be considered for backport to the next 1.18 minor release.

@gopherbot please open a backport issue to 1.18.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 13, 2022
@gopherbot gopherbot mentioned this issue Jun 13, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.4 milestone Jun 13, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/411934 mentions this issue: [release-branch.go1.18] cmd/compile: fix missing dict pass for type assertions

@randall77
Copy link
Contributor

This is a bug in the compiler which causes incorrect results for some generics type assertions.

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Jun 29, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 29, 2022
@gopherbot
Copy link
Author

Closed by merging 460a93b to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Jul 6, 2022
@cuonglm @heschi
[release-branch.go1.18] cmd/compile: fix missing dict pass for type a…
460a93b 
…ssertions

For type assertions, if either src or dst type has shape, we must
convert them to dynamic type assertions.

Fixes #53357

Change-Id: Ia3362fa67c011febcbdb5b26f856d081b5c366de
Reviewed-on: https://go-review.googlesource.com/c/go/+/411617
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/411934
Reviewed-by: Keith Randall <khr@google.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Jul 14, 2022
@cuonglm @bradfitz
[release-branch.go1.18] cmd/compile: fix missing dict pass for type a…
7264528 
…ssertions

For type assertions, if either src or dst type has shape, we must
convert them to dynamic type assertions.

Fixes golang#53357

Change-Id: Ia3362fa67c011febcbdb5b26f856d081b5c366de
Reviewed-on: https://go-review.googlesource.com/c/go/+/411617
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/411934
Reviewed-by: Keith Randall <khr@google.com>
@gopherbot
Copy link
Author

Change https://go.dev/cl/417615 mentions this issue: [release-branch.go1.18] cmd/compile: revert "fix missing dict pass for type assertions"

gopherbot pushed a commit that referenced this issue Jul 27, 2022
@mdempsky @cherrymui
[release-branch.go1.18] cmd/compile: revert "fix missing dict pass fo…
6ff8801 
…r type assertions"

This reverts CL 411934 (commit 460a93b).

Fixes #53852.
Updates #53357.

Change-Id: I93d7015d8962d22ffd73128b038e4e7e7ca41c2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/417615
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.18.4
Development

No branches or pull requests
3 participants
@dr2chase @randall77 @gopherbot