Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/xml: panic: reflect: call of reflect.Value.CanInterface on zero Value #53350

Closed
catenacyber opened this issue Jun 13, 2022 · 4 comments
Closed

encoding/xml: panic: reflect: call of reflect.Value.CanInterface on zero Value #53350

catenacyber opened this issue Jun 13, 2022 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@catenacyber
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.17.6 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/catena/Library/Caches/go-build"
GOENV="/Users/catena/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/catena/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/catena/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.6"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/catena/go/src/github.com/catenacyber/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/pp/dc1dtf9x2js3v0jx_m010nqr0000gn/T/go-build4237848497=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.17.6 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.17.6
uname -v: Darwin Kernel Version 21.3.0: Wed Jan  5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_X86_64
ProductName:	macOS
ProductVersion:	12.2.1
BuildVersion:	21D62
lldb --version: lldb-1316.0.9.41
Apple Swift version 5.6 (swiftlang-5.6.0.323.62 clang-1316.0.20.8)
gdb --version: GNU gdb (GDB) 9.1

What did you do?

Run https://go.dev/play/p/ra2dv8stCSW

What did you expect to see?

The program finishing and printing somme dummy data

What did you see instead?

panic: reflect: call of reflect.Value.CanInterface on zero Value

goroutine 1 [running]:
reflect.Value.CanInterface(...)
	/usr/local/go-faketime/src/reflect/value.go:1419
encoding/xml.(*Decoder).unmarshal(0xc0000cc000, {0x0?, 0x0?, 0x7f1954429888?}, 0xc00009af20?)
	/usr/local/go-faketime/src/encoding/xml/read.go:339 +0x2526
encoding/xml.(*Decoder).DecodeElement(0x4d8b48?, {0x4a13a0?, 0x0?}, 0x0?)
	/usr/local/go-faketime/src/encoding/xml/read.go:151 +0x10e
encoding/xml.(*Decoder).Decode(...)
	/usr/local/go-faketime/src/encoding/xml/read.go:139
main.main()
	/tmp/sandbox1275475420/prog.go:18 +0x9c

Program exited.

Is this the expected behavior ?

Found by https://github.com/catenacyber/ngolo-fuzzing on oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=47962
@shaoliming123
Copy link

@catenacyber I think you should pass the address of the nilptr variable. if you pass nilptr drectly, the decode function would never put decoded data back to nilptr.

@seankhliao
Copy link
Member

I think this should return an error like json: https://go.dev/play/p/kNjctQM6294

@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 15, 2022
@shaoliming123
Copy link

@catenacyber can assign it to me ?

@shaoliming123 shaoliming123 mentioned this issue Jun 16, 2022
Closed
shaoliming123 pushed a commit to shaoliming123/go that referenced this issue Jun 16, 2022
@jacobishao
encoding/xml: fix nil pointer passed to xml Unmarshal function which …
f85252e 
…casue panic Fixes golang#53350
shaoliming123 pushed a commit to shaoliming123/go that referenced this issue Jun 16, 2022
@jacobishao
encoding/xml: fix nil pointer passed to xml Unmarshal function which …
caf7fdb 
…casue panic Fixes golang#53350
@gopherbot
Copy link

Change https://go.dev/cl/412634 mentions this issue: encoding/xml: fix nil pointer passed to xml Unmarshal function which casues panic, Fixes #53350

shaoliming123 pushed a commit to shaoliming123/go that referenced this issue Jun 16, 2022
@jacobishao
encoding/xml: fix nil pointer passed to xml Unmarshal function which …
7117f40 
…casue panic

the interface which data marshal into should be a non-nil pointer. just like json Unmarshal function, when the input interface is not a pointer or nil pointer, the Unmarshal function should return an error instead panic.

Fixes golang#53350
shaoliming123 pushed a commit to shaoliming123/go that referenced this issue Jun 16, 2022
@jacobishao
encoding/xml: fix nil pointer passed to xml Unmarshal function which …
429d5ac 
…casue panic

the interface which data marshal into should be a non-nil pointer. just like json Unmarshal function, when the input interface is not a pointer or nil pointer, the Unmarshal function should return an error instead panic.

Fixes golang#53350
shaoliming123 pushed a commit to shaoliming123/go that referenced this issue Jun 16, 2022
@jacobishao
encoding/xml: fix nil pointer passed to xml Unmarshal function which …
a1da203 
…casue panic

the interface which data marshal into should be a non-nil pointer. just like json Unmarshal function, when the input interface is not a pointer or nil pointer, the Unmarshal function should return an error instead panic.

Fixes golang#53350
shaoliming123 pushed a commit to shaoliming123/go that referenced this issue Jun 17, 2022
@jacobishao
encoding/xml: check nil pointer for DecodeElement
99b3212 
the interface which data marshal into should be a non-nil pointer. just like json Unmarshal function, when the input interface is not a pointer or nil pointer, the Unmarshal function should return an error instead panic.

Fixes golang#53350
shaoliming123 pushed a commit to shaoliming123/go that referenced this issue Jun 17, 2022
@jacobishao
encoding/xml: check nil pointer for DecodeElement
45add12 
the interface which data marshal into should be a non-nil pointer. just like json Unmarshal function, when the input interface is not a pointer or nil pointer, the Unmarshal function should return an error instead panic.

Fixes golang#53350
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@jacobishao @jproberts
encoding/xml: check nil pointer in DecodeElement
012a443 
Fixes golang#53350

Change-Id: Id5e1f4016db5f1d4349ee1a76a9dfe3aeae83cee
GitHub-Last-Rev: 45add12
GitHub-Pull-Request: golang#53407
Reviewed-on: https://go-review.googlesource.com/c/go/+/412634
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

encoding/xml: check nil pointer in DecodeElement shaoliming123/go
4 participants
@gopherbot @seankhliao @catenacyber @shaoliming123