Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: the GC guide URL of Go 1.19 Release Notes is invalid. #53337

Closed
uji opened this issue Jun 12, 2022 · 7 comments
Closed

x/website: the GC guide URL of Go 1.19 Release Notes is invalid. #53337

uji opened this issue Jun 12, 2022 · 7 comments
Labels
FrozenDueToAge release-blocker website
Milestone
Go1.19

Comments

@uji
Copy link
Contributor

uji commented Jun 12, 2022

What did you do?

I accessed https://tip.golang.org/doc/go1.19 and opened the GC guide URL.

スクリーンショット 2022-06-12 15 21 11

What did you expect to see?

It should be accessible.

What did you see instead?

There was no page.

image
@gopherbot gopherbot added this to the Unreleased milestone Jun 12, 2022
@changkun
Copy link
Member

cc @prattmic @mknyszek

@narqo
Copy link
Contributor

narqo commented Jun 13, 2022

There is also the same "broken" link in the runtime/debug.SetMemoryLimit docs https://pkg.go.dev/runtime/debug@master#SetMemoryLimit

@prattmic
Copy link
Member

This is expected. We intend to have this doc ready by the 1.19 release so we went ahead and added a link to the draft release notes. I don't think we have a tracking issue for it though, so this will work nicely. :)

@prattmic prattmic modified the milestones: Unreleased, Go1.19 Jun 13, 2022
@mknyszek
Copy link
Contributor

Yeah, sorry about this everyone. I've been dealing with other issues but I'm finally getting around to this.

I think I want to put up a work-in-progress page there temporarily just so at the very least the link isn't broken and it's more clear what the current status is. Any objections?

@gopherbot
Copy link

Change https://go.dev/cl/411954 mentions this issue: _content/doc: add work-in-progress gc-guide.html

@mknyszek
Copy link
Contributor

@prattmic I created a new issue to track work on this actually, just because the original post on this issue refers specifically to the broken link. See #53360.

@gopherbot
Copy link

Change https://go.dev/cl/411974 mentions this issue: doc/go1.19: prefer relative links to other parts of the Go website

gopherbot pushed a commit that referenced this issue Jun 13, 2022
@dmitshur @gopherbot
doc/go1.19: prefer relative links to other parts of the Go website
24b9039 
The Go website can be served on more than one domain (for example,
go.dev, golang.google.cn, tip.golang.org, localhost:6060, and so on).
Use relative links which work in all contexts.

For #51400.
Updates #53337.

Change-Id: I100938981447537ac242b4045929f6db8a2674c2
Reviewed-on: https://go-review.googlesource.com/c/go/+/411974
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge release-blocker website
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
6 participants
@narqo @mknyszek @prattmic @changkun @gopherbot @uji