Skip to content

x/build/cmd/relui: add stop button to workflow #53317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toothrot opened this issue Jun 9, 2022 · 1 comment
Closed

x/build/cmd/relui: add stop button to workflow #53317

toothrot opened this issue Jun 9, 2022 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Jun 9, 2022

A workflow may need to be aborted early. We could easily cancel the context it's using, as we are already keeping track of running workflow IDs in our worker.

In the case of a recent beta release, a workflow is pending on waiting for a task that will never complete (a manual approval step). We should be able to stop this workflow and fail it.
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 9, 2022
@toothrot toothrot added this to the Unreleased milestone Jun 9, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 9, 2022
@toothrot toothrot self-assigned this Jun 9, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/411062 mentions this issue: internal/relui: add stop button to relui

gopherbot pushed a commit to golang/build that referenced this issue Jun 14, 2022
@toothrot @gopherbot
internal/relui: add stop button to relui
f212a15 
Adds a stop button which cancels the workflow's context. Also, style the
buttons on the workflow page a little nicer.

Removes a guard around workflow cancellation that doesn't appear to be
strictly necessary. We still want to mark the task failed in this (and
probably most) scenarios.

Updates test docker target to include workflow package.

Updates golang/go#53317

Change-Id: Ib5df013d23345e9ebe0dc56c10ad27843efe3448
Reviewed-on: https://go-review.googlesource.com/c/build/+/411062
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @cagedmantis @gopherbot