-
Notifications
You must be signed in to change notification settings - Fork 18k
x/tools/gopls: Default setting of GOPROXY=off causes problems with downloading modules #53313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this a problem only when the mod file changes or during startup as well? |
startup as well |
Hmm, the initial workspace load is supposed to allow network access. Also: does Could you share logs from your gopls session? |
for what it's worth, NixOS/nixpkgs#177632 was diagnosed to be due to dns resolution issues. I will open another issue because the error ends up being misleading and that is a problem of itself, but maybe there are dns issues going on here too? |
Regarding the above mention on NixOS/nixpkgs#177632, see #53676 |
As explained in #53676 (comment) Ideally, the required modules should be already locally available in the module cache, or users should explicitly request to download them ( |
gopls version
go env
What did you do?
Hi, I recently upgraded from a gopls version from over a year ago (0.1.0). I was getting an error
module lookup disabled by GOPROXY=off
but my project (kubernetes) has no private repos. (It does use a mod file with replace directives and a vendor directory).As a fix, I was able to fix the problem via toggling
allowImplicitNetworkAccess
, but it looks like this is not recommended. I'm not sure if this is a problem with my environment or the go.mod for Kubernetes (everything works smoothly for other repos).Editor and settings
Emacs, using lsp-mode and gopls
Logs
The text was updated successfully, but these errors were encountered: