Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime, cmd/go, cmd/dist: enable -msan on freebsd/amd64 #53298

Closed
dmgk opened this issue Jun 8, 2022 · 4 comments
Closed

runtime, cmd/go, cmd/dist: enable -msan on freebsd/amd64 #53298

dmgk opened this issue Jun 8, 2022 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Milestone
Unplanned

Comments

@dmgk
Copy link
Member

dmgk commented Jun 8, 2022

Currently the memory sanitizer is supported only on linux/amd64 and linux/arm64. This set of CLs enables msan support also on freebsd/amd64.
@gopherbot
Copy link

Change https://go.dev/cl/411275 mentions this issue: cmd/go: enable -msan on freebsd/amd64

@gopherbot
Copy link

Change https://go.dev/cl/411274 mentions this issue: runtime: add msan support on freebsd/amd64

@gopherbot
Copy link

Change https://go.dev/cl/411276 mentions this issue: cmd/dist, misc/cgo/testsanitizers: enable msan tests on freebsd/amd64

@cherrymui cherrymui added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD labels Jun 8, 2022
@cherrymui cherrymui added this to the Unplanned milestone Jun 8, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
gopherbot pushed a commit that referenced this issue Oct 14, 2022
@dmgk
runtime: add msan support on freebsd/amd64
5fde02e 
Adjust build constraints and change the runtime to call the C mmap function
when using cgo.

R=go1.20

For #53298

Change-Id: If9c3306dc16a8645d1bb9be0343e0472d6c4783f
Reviewed-on: https://go-review.googlesource.com/c/go/+/411274
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
gopherbot pushed a commit that referenced this issue Oct 14, 2022
@dmgk
cmd/go: enable -msan on freebsd/amd64
e56c93f 
Enable -msan flag on freebsd/amd64 and amend PIE comment in
internal/work/init.go to indicate that MSAN requires PIE on all platforms
except linux/amd64.

R=go1.20

For #53298

Change-Id: I93d94efa95d7f292c23c433fb1d3f4301d820bde
Reviewed-on: https://go-review.googlesource.com/c/go/+/411275
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
gopherbot pushed a commit that referenced this issue Oct 14, 2022
@dmgk
cmd/dist, misc/cgo/testsanitizers: enable msan tests on freebsd/amd64
a4b4717 
Adjust os/arch checks to enable msan tests on freebsd/amd64.

R=go1.20

For #53298

Change-Id: I3d0f5259db73d526d006a12de5ba6284528cf819
Reviewed-on: https://go-review.googlesource.com/c/go/+/411276
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
@dmgk @romaindoumenc
runtime: add msan support on freebsd/amd64
fd06770 
Adjust build constraints and change the runtime to call the C mmap function
when using cgo.

R=go1.20

For golang#53298

Change-Id: If9c3306dc16a8645d1bb9be0343e0472d6c4783f
Reviewed-on: https://go-review.googlesource.com/c/go/+/411274
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
@dmgk @romaindoumenc
cmd/go: enable -msan on freebsd/amd64
8ceca03 
Enable -msan flag on freebsd/amd64 and amend PIE comment in
internal/work/init.go to indicate that MSAN requires PIE on all platforms
except linux/amd64.

R=go1.20

For golang#53298

Change-Id: I93d94efa95d7f292c23c433fb1d3f4301d820bde
Reviewed-on: https://go-review.googlesource.com/c/go/+/411275
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
@dmgk @romaindoumenc
cmd/dist, misc/cgo/testsanitizers: enable msan tests on freebsd/amd64
a3fa036 
Adjust os/arch checks to enable msan tests on freebsd/amd64.

R=go1.20

For golang#53298

Change-Id: I3d0f5259db73d526d006a12de5ba6284528cf819
Reviewed-on: https://go-review.googlesource.com/c/go/+/411276
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@dmgk
Copy link
Member Author

dmgk commented Dec 12, 2022

Merged to master, closing as completed.

@dmgk dmgk closed this as completed Dec 12, 2022
@golang golang locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@dmgk @gopherbot @cherrymui