Skip to content

x/build/cmd/relui: add manual button task #53295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toothrot opened this issue Jun 8, 2022 · 5 comments
Closed

x/build/cmd/relui: add manual button task #53295

toothrot opened this issue Jun 8, 2022 · 5 comments
Assignees
@toothrot
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Jun 8, 2022

When testing our release process, sometimes we want to wait for a human intervention before moving forward in the workflow. We could trivially add a task type that does nothing, but is completed by a button-press in the UI.

In #51797, we plan on using this as a verification step when testing our new release process.
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 8, 2022
@toothrot toothrot added this to the Unreleased milestone Jun 8, 2022
@toothrot toothrot self-assigned this Jun 8, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 8, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/411199 mentions this issue: internal/relui: add approval step to build workflow

gopherbot pushed a commit to golang/build that referenced this issue Jun 9, 2022
@toothrot
internal/relui: add approval step to build workflow

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0f1fd27 
This change adds a manual approval task to the build before making any
user-facing changes. It uses a sentinel log entry in the approval task's
log in order to verify whether a human has approved the workflow to
continue.

Ideally, we'd change the data model to allow for this, perhaps by adding
a specific type of task, or a special state column, but this should be
sufficient for testing the beta release. Also, there should be some
shared definition of approval, but leaving that for a follow-up CL.

Updates golang/go#53295
Updates golang/go#51797

Change-Id: Iacd8c8a3ba59f9e3a343916dbe1a3a8ba59ce80c
Reviewed-on: https://go-review.googlesource.com/c/build/+/411199
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/413427 mentions this issue: internal/relui: add approved_at to tasks

@toothrot
Copy link
Contributor Author

We should also consider adding a column to stop relying on the magic task name prefix APPROVE-

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/413575 mentions this issue: internal/relui: stop relying on approval task name

gopherbot pushed a commit to golang/build that referenced this issue Jun 22, 2022
@toothrot @gopherbot
internal/relui: add approved_at to tasks
900dd35 
This change adds an approved_at column to the tasks table for checking
task approval, replacing the flimsy log-based determination for whether
a task has been approved.

Updates golang/go#53295

Change-Id: I3c2bd73134dc4a81e13c328aa085065a7b24a5d5
Reviewed-on: https://go-review.googlesource.com/c/build/+/413427
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Alex Rakoczy <alex@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/413580 mentions this issue: internal/relui: render artifacts without targets

gopherbot pushed a commit to golang/build that referenced this issue Jun 23, 2022
@toothrot @gopherbot
internal/relui: render artifacts without targets
65ed010 
Some of our older artifact results may not have a target. We should
still be able to render the page regardless.

Cleans up a duplicative variable in the home template.

For golang/go#53295

Change-Id: I55f56bb1dd71b828c262869173af34e95799d6fa
Reviewed-on: https://go-review.googlesource.com/c/build/+/413580
Run-TryBot: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@toothrot toothrot

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot