Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/netip: ParsePrefix, missing closing brace in errorstring(s), just a glitch in chunking the string(s) #53283

Closed
gaissmai opened this issue Jun 8, 2022 · 2 comments
Closed

net/netip: ParsePrefix, missing closing brace in errorstring(s), just a glitch in chunking the string(s) #53283

gaissmai opened this issue Jun 8, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@gaissmai
Copy link

gaissmai commented Jun 8, 2022 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.18.3 linux/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/gaissmai/.cache/go-build"
GOENV="/home/gaissmai/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/gaissmai/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/gaissmai/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/snap/go/9848"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/snap/go/9848/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.3"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/gaissmai/project/go/src/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2290714107=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.18.3 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.18.3
uname -sr: Linux 5.13.0-46-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 21.10
Release:	21.10
Codename:	impish
gdb --version: GNU gdb (Ubuntu 11.1-0ubuntu2) 11.1

What did you do?

https://go.dev/play/p/iq6YINEIlGH

What did you expect to see?

netip.ParsePrefix("::/130"): prefix length out of range
netip.ParsePrefix("::/five"): bad bits after slash: "five"

What did you see instead?

netip.ParsePrefix("::/130": prefix length out of range
netip.ParsePrefix("::/five": bad bits after slash: "five"
@shmsr
Copy link
Contributor

shmsr commented Jun 8, 2022

I looked at netip's source and I've found the issue. I'll send a fix for this.

@gopherbot
Copy link

Change https://go.dev/cl/411015 mentions this issue: netip: fix error messages in ParsePrefix

@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 8, 2022
@cherrymui cherrymui added this to the Backlog milestone Jun 8, 2022
@golang golang locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@gaissmai @gopherbot @cherrymui @shmsr