Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: error messages sometimes use x|y and sometimes x | y for union terms #53279

Closed
griesemer opened this issue Jun 7, 2022 · 10 comments
Closed

go/types, types2: error messages sometimes use x|y and sometimes x | y for union terms #53279

griesemer opened this issue Jun 7, 2022 · 10 comments
Assignees
@griesemer
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@griesemer
Copy link
Contributor

Reminder issue: Should use consistent spacing for union terms in error messages.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 7, 2022
@griesemer griesemer added this to the Go1.19 milestone Jun 7, 2022
@griesemer griesemer self-assigned this Jun 7, 2022
@griesemer
Copy link
Contributor Author

cc: @findleyr

@griesemer
Copy link
Contributor Author

Decision: use x | y to match gofmt.

@gopherbot
Copy link

Change https://go.dev/cl/410955 mentions this issue: go/types, types2: consistently write "x | y" rather than "x|y" for unions

@gopherbot
Copy link

Change https://go.dev/cl/410994 mentions this issue: internal: re-enable adjusted tests

@gopherbot
Copy link

Change https://go.dev/cl/410956 mentions this issue: internal: temporarily disable tests so we can land CL 410955

gopherbot pushed a commit to golang/tools that referenced this issue Jun 8, 2022
@griesemer
internal: temporarily disable tests so we can land CL 410955
5ca4cc8 
For golang/go#53279.

Change-Id: I3e0a502f8f0789ff9920af504ea8c86812bf49a1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/410956
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@ianlancetaylor
Copy link
Contributor

@griesemer Anything left to do for this issue? Thanks.

@griesemer
Copy link
Contributor Author

CLs are present but I ran into problems with x/tools. Will try again.

@griesemer
Copy link
Contributor Author

Haven't gotten around to this. Not urgent. Moving to 1.20.

@griesemer griesemer modified the milestones: Go1.19, Go1.20 Jul 1, 2022
@gopherbot
Copy link

Change https://go.dev/cl/428054 mentions this issue: x/tools/internal/lsp/source: disable some tests for std lib changes

gopherbot pushed a commit to golang/tools that referenced this issue Sep 2, 2022
@griesemer @gopherbot
x/tools/internal/lsp/source: disable some tests for std lib changes
5ba8541 
CL 410955 changes printing of unions which breaks a few lsp tests.
Disable them for now so we can submit CL 410955.

For golang/go#53279.
For golang/go#54822.

Change-Id: I54ff99a4f5530181a39557b6b62e776af082c28d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428054
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/428055 mentions this issue: x/tools/internal/typeparams: disable some tests for std lib changes

gopherbot pushed a commit to golang/tools that referenced this issue Sep 2, 2022
@griesemer @gopherbot
x/tools/internal/typeparams: use regexp to match wanted result
6a585a2 
CL 410955 changes printing of unions which breaks two typeparams tests.
Use regexp matching and adjust the wanted results accordingly.

For golang/go#53279.
For golang/go#54822.

Change-Id: I7060df47d36ce3069570237dafff024aaad637a5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428055
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
CarlosRosuero pushed a commit to CarlosRosuero/typeparams that referenced this issue Jun 13, 2023
@griesemer
internal: temporarily disable tests so we can land CL 410955
2b9d462 
For golang/go#53279.

Change-Id: I3e0a502f8f0789ff9920af504ea8c86812bf49a1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/410956
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
CarlosRosuero pushed a commit to CarlosRosuero/typeparams that referenced this issue Jun 13, 2023
@griesemer @gopherbot
x/tools/internal/typeparams: use regexp to match wanted result
736510f 
CL 410955 changes printing of unions which breaks two typeparams tests.
Use regexp matching and adjust the wanted results accordingly.

For golang/go#53279.
For golang/go#54822.

Change-Id: I7060df47d36ce3069570237dafff024aaad637a5
Reviewed-on: https://go-review.googlesource.com/c/tools/+/428055
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
@golang golang locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@griesemer griesemer

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Release Status & Release Blockers
Status: Done
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@ianlancetaylor @griesemer @gopherbot