Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/env/windows: remote desktop client is unreliable on gomote instances. #53272

Open
2 tasks
cagedmantis opened this issue Jun 7, 2022 · 2 comments
Open
2 tasks

x/build/env/windows: remote desktop client is unreliable on gomote instances. #53272

cagedmantis opened this issue Jun 7, 2022 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

The use of remote desktop client is inconsistent across all of the Windows builders in the infrastructure.

  • If possible, ensure all versions of the Windows builders have RDP enabled.
  • Add RDP capability to the GRPC gomote command. This should be enabled by tunneling RDP through SSH. The coordinator SSH server should be modified to enable tunneling.

@golang/release
@cagedmantis cagedmantis added help wanted OS-Windows Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 7, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jun 7, 2022
@cagedmantis cagedmantis modified the milestones: Unreleased, Backlog Jun 7, 2022
@cagedmantis
Copy link
Contributor Author

A possible implementation would be to enable port forwarding on the coordinator's SSH server. An SSH connection could be established with the target gomote instance and then forward the RDP traffic to it.

@gopherbot
Copy link

Change https://go.dev/cl/456044 mentions this issue: cmd/gomote: remove legacy gomote functions

gopherbot pushed a commit to golang/build that referenced this issue Dec 12, 2022
@cagedmantis @gopherbot
cmd/gomote: remove legacy gomote functions
d86daaa 
This removes the functions which used the depricated gomote API.

Updates golang/go#54735
Updates golang/go#53272

Change-Id: I12d2ce823f140f510186109e2755cca8461a30b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/456044
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot