x/build/cmd/gomote: missing entries in push exclusion list #53221
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
What version of Go are you using (
go version
)?linux/amd64 tip (1.19)
Does this issue reproduce with the latest release?
yes
What did you do?
When using gomotes, a problem that significantly slows me down is that any time I rebuild the Go linker it seems that I'm then forced to rerun "make.bash/make.bat" after my first relink.
Here is an example. I lease a gomote, do a push, and run make.bat:
% gomote push user-thanm-windows-386-2012-0
...
% gomote run -path '$PATH,$WORKDIR/go/bin' -e 'GOROOT=c:\workdir\go' user-thanm-windows-386-2012-0 go/src/make.bat
Building Go cmd/dist using C:\workdir\go1.4
Building Go toolchain1 using C:\workdir\go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for windows/386.
...
%
At this point I have a working copy of the tools on the gomote, and I can run tests, etc. However here's what happens when I push and rebuild the linker:
% gomote push user-thanm-windows-386-2012-0
% gomote run -e 'GOROOT=c:\workdir\go' user-thanm-windows-386-2012-0 go/bin/go.exe install cmd/link
... build succeeds ...
%
The first relink of the linker works, but then if I then execute exactly the same thing again, here's what happens:
% gomote push user-thanm-windows-386-2012-0
% gomote run -e 'GOROOT=c:\workdir\go' user-thanm-windows-386-2012-0 go/bin/go.exe install cmd/link
cmd/link
C:\Users\gopher\AppData\Local\go-build\39\397fad6defe75720ba990278c1b34e78985380df43d69defe2a412f5e4cdfc41-d(go.o): linked object header mismatch:
have "go object windows 386 devel gomote.XXXXX X:\n"
want "go object windows 386 devel go1.19-a8db95e9fd Thu Jun 2 09:12:44 2022 -0400 X:\n"
c:\workdir\go\pkg\windows_386\cmd\internal\sys.a(go.o): linked object header mismatch:
have "go object windows 386 devel gomote.XXXXX X:\n"
want "go object windows 386 devel go1.19-a8db95e9fd Thu Jun 2 09:12:44 2022 -0400 X:\n"
What did you expect to see?
Clean relink
What did you see instead?
As above.
Problem seems to be inconsistencies in the "push" exclusion list in cmd/gomote (it is pushing things generated by go tool dist that it should not).
The text was updated successfully, but these errors were encountered: