Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: tweet workflow didn't register task failure #53207

Closed
toothrot opened this issue Jun 2, 2022 · 3 comments
Closed

x/build/cmd/relui: tweet workflow didn't register task failure #53207

toothrot opened this issue Jun 2, 2022 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Jun 2, 2022 •
edited

When publishing the tweet for go1.17.11 and go1.18.3, the workflow failed with a tweet-length error, however that error was not successfully saved to the database.

2022/06/01 21:06:14 TaskStateChanged("[REDACTED]", "tweet-minor", &workflow.TaskState{Name:"tweet-minor", Finished:true, Result:"", SerializedResult:[]uint8(nil), Error:"tweet text length exceeded Twitter's limit"})

In the UI, this shows up as a successful entry. This means we've either failed to save or load the state after task completion.
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 2, 2022
@toothrot toothrot added this to the Unreleased milestone Jun 2, 2022
@toothrot toothrot self-assigned this Jun 2, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jun 2, 2022
@toothrot
Copy link
Contributor Author

toothrot commented Jun 2, 2022

/cc @dmitshur, who reported this issue during yesterday's release.

@toothrot toothrot added this to In Progress in Go Release Team Jun 2, 2022
@gopherbot
Copy link

Change https://go.dev/cl/410236 mentions this issue: internal/relui: record task errors

@gopherbot
Copy link

Change https://go.dev/cl/410237 mentions this issue: internal/relui: record and display workflow errors

gopherbot pushed a commit to golang/build that referenced this issue Jun 7, 2022
@toothrot
internal/relui: record task errors
4de9449 
This change introduces recording of task failures to the database. It
also improves UX of failures in the UI.

Updates golang/go#53207

Change-Id: Ic00c9a94228d3fc61c5b2e6da6f0b25d1c7d19dc
Reviewed-on: https://go-review.googlesource.com/c/build/+/410236
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Jun 7, 2022
@toothrot
internal/relui: record and display workflow errors
ac7906f 
This changes the postgres workflow listener to record workflow errors on
workflow completion. It adds the workflow state, output, and errors to
the UI.

Updates golang/go#53207

Change-Id: Idac3eace1b06b05de89dc634e9b58df66157cf22
Reviewed-on: https://go-review.googlesource.com/c/build/+/410237
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@dmitshur dmitshur moved this from In Progress to Done in Go Release Team Jun 7, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @cagedmantis @gopherbot