Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.8.5 #53173

Closed
1 of 9 tasks
hyangah opened this issue Jun 1, 2022 · 2 comments
Closed
1 of 9 tasks

x/tools/gopls: release version v0.8.5 #53173

hyangah opened this issue Jun 1, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.5

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 1, 2022 •
edited

This issue tracks progress toward releasing gopls@v0.8.5 - v0.8.5 is a patch release to address #53080 whose fix is a low risk, trivial change.

  • cherry-pick cls to gopls-release-branch.0.8
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version) Unnecessary
  • tag gopls/v0.8.5-pre.1
  • update Github milestone
  • write release notes
  • smoke test features
  • tag gopls/v0.8.5

cc @golang/tools-team
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 1, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jun 1, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/v0.8.5 Jun 1, 2022
@hyangah
Copy link
Contributor Author

hyangah commented Jun 3, 2022

https://go-review.googlesource.com/c/tools/+/409674 is blocked due to the golang.org/x/tools/go/gcexportdata test failure - the x/tools in the v0.8 release branch needs update to work with tip. The test failure is unrelated to the change, but blocks complete test runs. So, we don't want to release in this state regardless how trivial the change is.

It's likely we will abandon this plan and proceed to prepare for v0.9.0 (and tag of x/tools too)

@hyangah
Copy link
Contributor Author

hyangah commented Jun 7, 2022

Abandoning. We will release gopls/v0.9.0 late this month instead.

@hyangah hyangah closed this as completed Jun 7, 2022
@golang golang locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.5
Development

No branches or pull requests
2 participants
@hyangah @gopherbot