Skip to content

x/build/cmd/relui: manually retry failed tasks #53165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toothrot opened this issue May 31, 2022 · 4 comments
Closed

x/build/cmd/relui: manually retry failed tasks #53165

toothrot opened this issue May 31, 2022 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented May 31, 2022 •
edited
Loading

In relui, tasks occasionally fail. It would be nice if there were an mechanism for retrying a task. This is particularly important for the release test stage, which can be flaky.
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label May 31, 2022
@toothrot toothrot added this to the Unreleased milestone May 31, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 31, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Jun 1, 2022 •
edited
Loading

This will be very helpful.

Just mentioning that task.ErrTweetTooLong is one example of an error that we know to be non-retryable (for the same input) in contrast to a networking error, and so it can be used if we're looking for some test case for supporting that as part of configuring retryable tasks.

@toothrot toothrot self-assigned this Jun 7, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/411075 mentions this issue: internal/relui: lock concurrent runs of a workflow

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/411074 mentions this issue: internal/relui: add manual retry button to failed tasks

gopherbot pushed a commit to golang/build that referenced this issue Jun 8, 2022
@toothrot
internal/relui: lock concurrent runs of a workflow
e0fc1fe 
This change adds a map containing a list of running workflow ids along
with a lock. Attempting to re-start a running workflow will log an error.

Updates golang/go#53165

Change-Id: I8eb144a2920ec8da17edbc5bbd722279721420f6
Reviewed-on: https://go-review.googlesource.com/c/build/+/411075
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Jun 8, 2022
@toothrot
internal/relui: add manual retry button to failed tasks
e533642 
Sometimes, tasks fail. This change adds an ability for the user to retry
specific tasks in a workflow. Retrying a task will reset the state of
the task, clear the state of the workflow, and restart the workflow to
retry the task.

This also fixes an issue resuming pending tasks that have no output to
unmarshal.

Adds httprouter for routing nested parameter routes.

Updates golang/go#53165

Change-Id: I9a899d1e6e0d5d9511648b478148a665459aae72
Reviewed-on: https://go-review.googlesource.com/c/build/+/411074
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@toothrot toothrot changed the title x/build/cmd/relui: retry failed tasks x/build/cmd/relui: manually retry failed tasks Jun 8, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/411194 mentions this issue: internal/relui: log previous state when retrying tasks

@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot